SRU Vivid - Backport ESRT support

Mario_Limonciello at Dell.com Mario_Limonciello at Dell.com
Thu Jul 16 13:22:52 UTC 2015


Hi Colin,

Yes, I validated a backport of that set of ESRT patches on hardware that supports ESRT.  The kernel interface is working appropriately.

Thanks,

-----Original Message-----
From: Anthony Wong [mailto:anthony.wong at canonical.com] 
Sent: Thursday, July 16, 2015 4:06 AM
To: Colin Ian King
Cc: Tim Gardner; kernel-team; Limonciello, Mario
Subject: Re: SRU Vivid - Backport ESRT support

Mario has tested the esrt patches, he should be able to confirm.

Thanks,
Anthony

On 15 July 2015 at 18:25, Colin Ian King <colin.king at canonical.com> wrote:
> I'm not seeing and SRU justification or test case for this SRU.
>
> Has this been tested check if the newly exposed interfaces work OK?
>
> Patches:
>
> efi: Rename efi_guid_unparse to efi_guid_to_str
>         - minor function naming, ACK
> Add a "debug" option to the efi= cmdline
>         - extra debug, ACK
> efi: efivar_create_sysfs_entry() should return negative error codes
>         - fix error return style, ACK
> efi: Add esrt support
>         - extra ESRT functionality, clean cherry pick, ACK x86, doc: 
> Remove cmdline_size from list of fields to be filled in for EFI 
> handover
>         - trivial documentation change, ACK
> efi/esrt: Fix some compiler warnings
>         - looks sane, ACK
> efi: dmi: List SMBIOS3 table before SMBIOS table
>         - this does change the entries to /sys/firmware/efi/systab, 
> apparently dmidecode does not support SMBIOS 3.0 (nor does fwts), so 
> SMBIOS3 enabled f/w with this interface change may make some userland 
> tools get confused.  I think I may need to fix fwts for this.
>         - ACK (with comments)
>
> efi: Add 'systab' information to Documentation/ABI
>         - trivial documentation change, ACK
>
>
> All clean cherry picks or trivial backports, so looks OK to me.
>
>
> On 13/07/15 22:22, Tim Gardner wrote:
>> http://bugs.launchpad.net/bugs/1473341
>>
>> The following changes since commit
>> 632ef3a5ba8f3c54d696b6a9ea0fed46ad049b7d:
>>
>>   net/mlx4_core: need to call close fw if alloc icm is called twice
>> (2015-07-13 14:02:49 -0700)
>>
>> are available in the git repository at:
>>
>>   git://kernel.ubuntu.com/rtg/ubuntu-vivid.git esrt
>>
>> for you to fetch changes up to c5fcfdcd8d7c944eaf39b356ac48262f0b7ae891:
>>
>>   efi: Add 'systab' information to Documentation/ABI (2015-07-13
>> 15:17:11 -0600)
>>
>> ----------------------------------------------------------------
>> Alex Smith (1):
>>       x86, doc: Remove cmdline_size from list of fields to be filled 
>> in for EFI handover
>>
>> Borislav Petkov (2):
>>       efi: Rename efi_guid_unparse to efi_guid_to_str
>>       x86/efi: Add a "debug" option to the efi= cmdline
>>
>> Dan Carpenter (1):
>>       efi: efivar_create_sysfs_entry() should return negative error 
>> codes
>>
>> Jean Delvare (1):
>>       efi: dmi: List SMBIOS3 table before SMBIOS table
>>
>> Matt Fleming (1):
>>       efi: Add 'systab' information to Documentation/ABI
>>
>> Peter Jones (2):
>>       efi: Add esrt support
>>       efi/esrt: Fix some compiler warnings
>>
>>  Documentation/ABI/testing/sysfs-firmware-efi      |  10 ++++
>>  Documentation/ABI/testing/sysfs-firmware-efi-esrt |  81
>> ++++++++++++++++++++++++++
>>  Documentation/kernel-parameters.txt               |   3 +-
>>  Documentation/x86/boot.txt                        |   1 -
>>  arch/x86/platform/efi/efi.c                       |   7 ++-
>>  block/partitions/efi.c                            |   2 +-
>>  drivers/firmware/efi/Makefile                     |   2 +-
>>  drivers/firmware/efi/efi.c                        |  95
>> ++++++++++++++++++++++++++++--
>>  drivers/firmware/efi/efivars.c                    |  17 +++---
>>  drivers/firmware/efi/esrt.c                       | 471
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>
>>  fs/efivarfs/super.c                               |   2 +-
>>  include/linux/efi.h                               |  13 ++++-
>>  12 files changed, 684 insertions(+), 20 deletions(-)  create mode 
>> 100644 Documentation/ABI/testing/sysfs-firmware-efi-esrt
>>  create mode 100644 drivers/firmware/efi/esrt.c
>


More information about the kernel-team mailing list