[3.16.y-ckt stable] Patch "usb: dwc3: gadget: return error if command sent to DEPCMD register fails" has been added to staging queue

Subbaraya Sundeep Bhatta subbaraya.sundeep.bhatta at xilinx.com
Wed Jul 15 07:54:02 UTC 2015


Hi Luis,

> -----Original Message-----
> From: Luis Henriques [mailto:luis.henriques at canonical.com]
> Sent: Monday, July 13, 2015 2:51 PM
> To: Subbaraya Sundeep Bhatta
> Cc: Subbaraya Sundeep Bhatta; Felipe Balbi; Luis Henriques; kernel-
> team at lists.ubuntu.com
> Subject: [3.16.y-ckt stable] Patch "usb: dwc3: gadget: return error if
> command sent to DEPCMD register fails" has been added to staging queue
>
> This is a note to let you know that I have just added a patch titled
>
>     usb: dwc3: gadget: return error if command sent to DEPCMD register fails
>
> to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree
> which can be found at:
>
>     http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.16.y-
> queue
>
> This patch is scheduled to be released in version 3.16.7-ckt15.
>
> If you, or anyone else, feels it should not be added to this tree, please reply
> to this email.

Just a head's up: this patch uncovered an IP bug for which we are working on a workaround patch.
Please wait.

Thanks,
Sundeep.B.S.

>
> For more information about the 3.16.y-ckt tree, see
> https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
>
> Thanks.
> -Luis
>
> ------
>
> From dc12ff9369405e5e85cf9f9f26632c8ec48e73a5 Mon Sep 17 00:00:00
> 2001
> From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta at xilinx.com>
> Date: Thu, 21 May 2015 15:46:48 +0530
> Subject: usb: dwc3: gadget: return error if command sent to DEPCMD
> register  fails
>
> commit 76e838c9f7765f9a6205b4d558d75a66104bc60d upstream.
>
> We need to return error to caller if command is not sent to controller
> succesfully.
>
> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta at xilinx.com>
> Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
> Signed-off-by: Felipe Balbi <balbi at ti.com> [ luis: backported to 3.16:
> adjusted context ]
> Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
> ---
>  drivers/usb/dwc3/gadget.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index
> 0c4a7aba42cb..0be560add2c2 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -414,6 +414,8 @@ int dwc3_send_gadget_ep_cmd(struct dwc3 *dwc,
> unsigned ep,
>               if (!(reg & DWC3_DEPCMD_CMDACT)) {
>                       dev_vdbg(dwc->dev, "Command Complete -->
> %d\n",
>                                       DWC3_DEPCMD_STATUS(reg));
> +                     if (DWC3_DEPCMD_STATUS(reg))
> +                             return -EINVAL;
>                       return 0;
>               }



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.





More information about the kernel-team mailing list