[all-ubuntu-kernels] UBUNTU: [Packaging] force "dpkg-source -I -i" behavior

[Stefan Bader]

On 16.01.2015 20:31, Kamal Mostafa wrote:
> On Fri, 2015-01-16 at 18:40 +0000, Andy Whitcroft wrote:
>> On Fri, Jan 16, 2015 at 09:45:22AM -0800, Kamal Mostafa wrote:
>>> I'd like some Ack's or contrary opinions on this before proceeding...
>>>
>>> We occasionally end up with .git directories or other cruft in our
>>> kernel source packages, when packagers forget to use the "-I -i" flags
>>> with debuild.  To avoid this problem, I propose that we enable the "-I
>>> -i" behavior by default for all of our kernel package branches by
>>> creating the file debian/source/options with these contents (see the
>>> dpkg-source man page for details):
>>>
>>>         # force "dpkg-source -I -i" behavior
>>>         diff-ignore
>>>         tar-ignore
>>
>> It seems safe enough to do indeed, assuming you tested the appropriate
>> chroots.  I assume there is no bad effects from them being in there,
>> and my also supplying the same options.
> 
> Correct.  This is equivalent to prepending "-I -i" to your command line
> options.
> 
> 
>>> I've tested the resulting behavior.  AFAICT, it works as desired in all
>>> branches.  Specifically, I intend to add it to the following branches:
>>
>> Also which chroots did you test this in ?
> 
> In the chroots they match, and also building the older packages in a
> trusty chroot.  The only "interesting" case is that in an ancient lucid
> chroot, dpkg-source does see the debian/source/options file, but does
> not support (happily ignores) those particular options:
> 
>         dpkg-source: info: using options from ubuntu-lucid/debian/source/options: --diff-ignore --tar-ignore
>         dpkg-source: warning: --diff-ignore is not a valid option for Dpkg::Source::Package::V1
>         dpkg-source: warning: --tar-ignore is not a valid option for Dpkg::Source::Package::V1
> 
> But it still makes sense to add those options to lucid, for the benefit
> of users who construct their source packages in a newer-than-lucid
> chroot (*cough*).

*IF* those users would run in a Lucid chroot, they would end up with all of .git
in their source package because "-I -i" does not do things as you expect. For
Lucid ec2 I started to use "-I -i -I.git -i.git" which might be too much but
then we all wait for April and the "problem" going away naturally. :)

-Stefan

> 
> Chroots version >= precise have full support both options.
> 
> 
>>>         ubuntu-precise		lts-backport-trusty
>>                      		^^ should get its from its master-next upstream
> 
> Andy, are you saying that you think it will already pick up
> debian/source/options from its upstream?  (I don't think that's true;
> update-from-blah-master doesn't appear to rsync the debian/ dir).
> 
> Or are you saying that we should arrange for that to be true? (By making
> update-from-blah-master do that?)
> 
>>
>> Plus:
>>           ubuntu-vivid		unstable
>>           ubuntu-vivid-meta	unstable
>>           ubuntu-vivid-signed	unstable
> 
> Ok, added to my to-do list.
> 
>  -Kamal
> 
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20150119/171c584f/attachment.sig>