ACK w/ cmt: [PATCH][vivid/unstable] HID: i2c-hid: Limit reads to wMaxInputLength bytes for input events

[Seth Forshee]

On Wed, Feb 25, 2015 at 11:08:02AM +0000, Luis Henriques wrote:
> On Mon, Feb 23, 2015 at 03:17:23PM -0600, Seth Forshee wrote:
> > d1c7e29e8d27 (HID: i2c-hid: prevent buffer overflow in early IRQ)
> > changed hid_get_input() to read ihid->bufsize bytes, which can be
> > more than wMaxInputLength. This is the case with the Dell XPS 13
> > 9343, and it is causing events to be missed. In some cases the
> > missed events are releases, which can cause the cursor to jump or
> > freeze, among other problems. Limit the number of bytes read to
> > min(wMaxInputLength, ihid->bufsize) to prevent such problems.
> > 
> > Fixes: d1c7e29e8d27 "HID: i2c-hid: prevent buffer overflow in early IRQ"
> > Signed-off-by: Seth Forshee <seth.forshee at canonical.com>
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires at redhat.com>
> > Signed-off-by: Jiri Kosina <jkosina at suse.cz>
> > (cherry picked from commit 6d00f37e49d95e640a3937a4a1ae07dbe92a10cb
> >  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git)
> > ---
> > 
> > This should come in from upstream stable eventually, but for selfish
> > reasons I'd like to get it in sooner. I'm targeting 3.19 since I'm not
> > anticipating any more 3.18 releases for vivid, but it should apply fine
> > to 3.18 as well.
> >
> 
> Unfortunately this commit has *not* been tagged for stable.  Since
> we're having issues reported against utopic kernels as well (thanks
> for the heads-up Stephen), I'm queuing it for the 3.16 stable kernel.
> But it may be worth also SRU'ing it for utopic.

Oh, the wording in Documentation/SubmittingPatches lead me to believe
that including the Fixes tag was sufficient get the stable kernels to
pick it up. Apologies if I was mistaken.

It does seem like it would make sense though for the stable tooling to
trigger off those tags and see if the given sha1 is present in the
stable tree, both directly and via the "commit <foo> upstream" messages.

Seth