[regression] modprobe regression to several file-systems - related to crc32c

[Luis Henriques]

On Tue, Feb 10, 2015 at 12:04:08AM +0100, Philip Müller wrote:
> Hi there,
> 
> this info might be needful for 3.16.7-ckt6 release.
> 

Thank you, Philip.  As I already replied in a different thread, the
3.16 kernel already contains commit 06e5a1f29819 ("CRC32C: Add soft
module dependency to load other accelerated crc32c modules").  Thus,
the changes in 5d26a105b5a73e5635eae0629b42fa0a90e07b7b are already
applied to the correct file (crypto/crc32c_generic.c).

Cheers,
--
Luís

> kind regards
> Philip Müller
> 
> 
> -------- Weitergeleitete Nachricht --------
> Betreff: 	Re: [regression] modprobe regression to several file-systems -
> related to crc32c
> Datum: 	Mon, 9 Feb 2015 14:30:23 -0800
> Von: 	Kees Cook <keescook at chromium.org>
> An: 	Mathias Krause <minipli at googlemail.com>
> Kopie (CC): 	Greg Kroah-Hartman <gregkh at linuxfoundation.org>, Philip Müller
> <philm at manjaro.org>, Rob McCathie <rob at manjaro.org>, luis Henriques
> <luis.henriques at canonical.com>, Kamal Mostafa <kamal at canonical.com>, Jiri
> Slaby <jslaby at suse.cz>
> 
> 
> Ah! That's it, good find. Thanks!
> 
> -Kees
> 
> On Mon, Feb 9, 2015 at 2:15 PM, Mathias Krause <minipli at googlemail.com> wrote:
> >On 9 February 2015 at 23:05, Greg Kroah-Hartman
> ><gregkh at linuxfoundation.org> wrote:
> >>On Mon, Feb 09, 2015 at 01:26:17PM -0800, Kees Cook wrote:
> >>>But it DOES happen for me on 3.14.31. Hmmm.
> >>
> >>Did I mess up the backport somehow?
> >>
> >
> >v3.14.31:crypto/crc32c.c is missing the MODULE_ALIAS_CRYPTO("crc32c").
> >That's probably because crypto/crc32c.c was renamed to
> >crypto/crc32c_generic.c in commit
> >06e5a1f29819759392239669beb2cad27059c8ec and therefore fell through
> >the cracks when backporting commit
> >5d26a105b5a73e5635eae0629b42fa0a90e07b7b.
> >
> >So the affected kernels (all that backported the "crypto-" prefix
> >patches) need this additional patch:
> >
> >diff --git a/crypto/crc32c.c b/crypto/crc32c.c
> >index 06f7018c9d95..aae5829eb681 100644
> >--- a/crypto/crc32c.c
> >+++ b/crypto/crc32c.c
> >@@ -167,6 +167,7 @@ static void __exit crc32c_mod_fini(void)
> > module_init(crc32c_mod_init);
> > module_exit(crc32c_mod_fini);
> >
> >+MODULE_ALIAS_CRYPTO("crc32c");
> > MODULE_AUTHOR("Clay Haapala <chaapala at cisco.com>");
> > MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations wrapper for lib/crc32c");
> > MODULE_LICENSE("GPL");
> >
> >Mathias
> 
> -- 
> Kees Cook
> Chrome OS Security
> 
> 
> 

> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team