[3.16.y-ckt stable] Patch "bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in the irq handler" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Mon Feb 2 11:51:07 UTC 2015


This is a note to let you know that I have just added a patch titled

    bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in the irq handler

to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree 
which can be found at:

 http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.16.y-queue

This patch is scheduled to be released in version 3.16.7-ckt6.

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.16.y-ckt tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

------

>From cc7293b1a460c96406fda625c1a383ecd7c80772 Mon Sep 17 00:00:00 2001
From: Keerthy <j-keerthy at ti.com>
Date: Mon, 10 Nov 2014 23:49:48 +0530
Subject: bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in
 the irq handler

commit c4cf0935a2d8fe6d186bf4253ea3c4b4a8a8a710 upstream.

Correct returning IRQ_HANDLED unconditionally in the irq handler.
Return IRQ_NONE for some interrupt which we do not expect to be
handled in this handler. This prevents kernel stalling with back
to back spurious interrupts.

Fixes: 2722e56de6 ("OMAP4: l3: Introduce l3-interconnect error handling driver")
Acked-by: Nishanth Menon <nm at ti.com>
Signed-off-by: Keerthy <j-keerthy at ti.com>
Signed-off-by: Tony Lindgren <tony at atomide.com>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 drivers/bus/omap_l3_noc.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index b5eac29d8f6e..17d86595951c 100644
--- a/drivers/bus/omap_l3_noc.c
+++ b/drivers/bus/omap_l3_noc.c
@@ -222,10 +222,14 @@ static irqreturn_t l3_interrupt_handler(int irq, void *_l3)
 			}

 			/* Error found so break the for loop */
-			break;
+			return IRQ_HANDLED;
 		}
 	}
-	return IRQ_HANDLED;
+
+	dev_err(l3->dev, "L3 %s IRQ not handled!!\n",
+		inttype ? "debug" : "application");
+
+	return IRQ_NONE;
 }

 static const struct of_device_id l3_noc_match[] = {
--
2.1.4





More information about the kernel-team mailing list