[PATCH] [Vivid][SRU] hv_netvsc: Clean up two unused variables

[Andy Whitcroft]

On Fri, Dec 04, 2015 at 12:19:09PM +0900, Seyeong Kim wrote:
> From: Haiyang Zhang <haiyangz at microsoft.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1521053
> 
> The commit
> 
> hv_netvsc: Clean up two unused variables

As this commit only removes unused variables, it is not at all clear how
this could cause or fix network slowdowns.  The net effect is to remove
64 bytes from one structure, but this seems unlikely enough to cause
significant performance issues.

How was it determined that this was the fix?

-apw

> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com>
> Reviewed-by: K. Y. Srinivasan <kys at microsoft.com>
> Signed-off-by: David S. Miller <davem at davemloft.net>
> (backported from commit 0d158852a8089099a6959ae235b20f230871982f)
> Signed-off-by: Seyeong Kim <seyeong.kim at canonical.com>
> ---
>  drivers/net/hyperv/hyperv_net.h   | 1 -
>  drivers/net/hyperv/netvsc.c       | 1 -
>  drivers/net/hyperv/rndis_filter.c | 2 --
>  3 files changed, 4 deletions(-)
> 
> diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
> index bf2604b..ce9d49b 100644
> --- a/drivers/net/hyperv/hyperv_net.h
> +++ b/drivers/net/hyperv/hyperv_net.h
> @@ -129,7 +129,6 @@ struct hv_netvsc_packet {
>  	/* Bookkeeping stuff */
>  	u32 status;
>  
> -	struct hv_device *device;
>  	bool is_data_pkt;
>  	bool xmit_more; /* from skb */
>  	bool cp_partial; /* partial copy into send buffer */
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
> index b15041b..9e4a86f 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -1037,7 +1037,6 @@ static void netvsc_receive(struct netvsc_device *net_device,
>  	}
>  
>  	count = vmxferpage_packet->range_cnt;
> -	netvsc_packet->device = device;
>  	netvsc_packet->channel = channel;
>  
>  	/* Each range represents 1 RNDIS pkt that contains 1 ethernet frame */
> diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
> index 524cb82..11598f0 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -47,8 +47,6 @@ struct rndis_request {
>  
>  	/* Simplify allocation by having a netvsc packet inline */
>  	struct hv_netvsc_packet	pkt;
> -	/* Set 2 pages for rndis requests crossing page boundary */
> -	struct hv_page_buffer buf[2];
>  
>  	struct rndis_message request_msg;
>  	/*
> -- 
> 2.1.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team