[3.13.y-ckt stable] Patch "scsi_sysfs: Fix queue_ramp_up_period return code" has been added to staging queue

Kamal Mostafa kamal at canonical.com
Wed Dec 2 22:53:47 UTC 2015


This is a note to let you know that I have just added a patch titled

    scsi_sysfs: Fix queue_ramp_up_period return code

to the linux-3.13.y-queue branch of the 3.13.y-ckt extended stable tree 
which can be found at:

    http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.13.y-queue

This patch is scheduled to be released in version 3.13.11-ckt31.

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.13.y-ckt tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Kamal

------

>From e886db69b259c3303f23fce2dd5e10c3a8862bcb Mon Sep 17 00:00:00 2001
From: Peter Oberparleiter <oberpar at linux.vnet.ibm.com>
Date: Tue, 27 Oct 2015 10:49:54 +0100
Subject: scsi_sysfs: Fix queue_ramp_up_period return code

commit 863e02d0e173bb9d8cea6861be22820b25c076cc upstream.

Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
returns the value of that number instead of the number of bytes written.
This behavior can confuse programs expecting POSIX write() semantics.
Fix this by returning the number of bytes written instead.

Signed-off-by: Peter Oberparleiter <oberpar at linux.vnet.ibm.com>
Reviewed-by: Hannes Reinecke <hare at suse.de>
Reviewed-by: Matthew R. Ochs <mrochs at linux.vnet.ibm.com>
Reviewed-by: Ewan D. Milne <emilne at redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 drivers/scsi/scsi_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 8ff62c2..825f237 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -873,7 +873,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
 		return -EINVAL;

 	sdev->queue_ramp_up_period = msecs_to_jiffies(period);
-	return period;
+	return count;
 }

 static struct device_attribute sdev_attr_queue_ramp_up_period =
--
1.9.1





More information about the kernel-team mailing list