[3.19.y-ckt stable] Patch "HID: cp2112: fix to force single data-report reply" has been added to staging queue

Kamal Mostafa kamal at canonical.com
Thu Aug 27 22:07:46 UTC 2015


This is a note to let you know that I have just added a patch titled

    HID: cp2112: fix to force single data-report reply

to the linux-3.19.y-queue branch of the 3.19.y-ckt extended stable tree 
which can be found at:

    http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.19.y-queue

This patch is scheduled to be released in version 3.19.8-ckt6.

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.19.y-ckt tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Kamal

------

>From 8582a3a7442988e44ad7446e521fa225031ecf97 Mon Sep 17 00:00:00 2001
From: Antonio Borneo <borneo.antonio at gmail.com>
Date: Sun, 21 Jun 2015 14:20:25 +0800
Subject: HID: cp2112: fix to force single data-report reply

commit 6debce6f4e787a8eb4cec94e7afa85fb4f40db27 upstream.

Current implementation of cp2112_raw_event() only accepts one data report at a
time. If last received data report is not fully handled yet, a new incoming
data report will overwrite it. In such case we don't guaranteed to propagate
the correct incoming data.

The trivial fix implemented here forces a single report at a time by requesting
in cp2112_read() no more than 61 byte of data, which is the payload size of a
single data report.

Signed-off-by: Antonio Borneo <borneo.antonio at gmail.com>
Tested-by: Ellen Wang <ellen at cumulusnetworks.com>
Signed-off-by: Jiri Kosina <jkosina at suse.com>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 drivers/hid/hid-cp2112.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
index 3318de6..a2dbbbe 100644
--- a/drivers/hid/hid-cp2112.c
+++ b/drivers/hid/hid-cp2112.c
@@ -356,6 +356,8 @@ static int cp2112_read(struct cp2112_device *dev, u8 *data, size_t size)
 	struct cp2112_force_read_report report;
 	int ret;

+	if (size > sizeof(dev->read_data))
+		size = sizeof(dev->read_data);
 	report.report = CP2112_DATA_READ_FORCE_SEND;
 	report.length = cpu_to_be16(size);

--
1.9.1





More information about the kernel-team mailing list