APPLIED: [PULL v2][Trusty] arm64: EFI stub support

Tim Gardner tim.gardner at canonical.com
Fri Apr 24 18:07:53 UTC 2015


On 04/24/2015 01:02 PM, Dann Frazier wrote:
> On Fri, Apr 24, 2015 at 11:14 AM, Luis Henriques
> <luis.henriques at canonical.com> wrote:
>> Applied this patchset to Trusty master-next branch with a small
>> change:
>
> Thanks!
>
>> I moved patch
>>
>>   "UBUNTU: [Config] CONFIG_{EFI_PARAMS_FROM_FDT,GENERIC_EARLY_IOREMAP,LIBFDT}=y"
>>
>> to the top.
>
> Quick question on that. In the past I used to submit changes with the
> config tweaks added after the Kconfig options were added. However, I
> noticed that when they got merged, the config changes would get
> reordered to the beginning. I figured that was to aide bisecting
> since, if you land on a commit in between the two, the user would get
> prompted. In this case it doesn't matter - the user won't get prompted
> either way. I would like to learn how to do it correctly - could
> someone enlighten me? :)
>
>   -dann

Bisectability without adding Kconfig prompts is exactly why I reorder 
those commits.

-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list