[PATCH 3.13 026/103] md/raid10: fix memory leak when reshaping a RAID10.
kamal at canonical.com
Tue Sep 30 21:30:31 UTC 2014
18.104.22.168 -stable review patch. If anyone has any objections, please let me know.
From: NeilBrown <neilb at suse.de>
commit ce0b0a46955d1bb389684a2605dbcaa990ba0154 upstream.
raid10 reshape clears unwanted bits from a bio->bi_flags using
a method which, while clumsy, worked until 3.10 when BIO_OWNS_VEC
Since then it clears that bit but shouldn't. This results in a
So change to used the approved method of clearing unwanted bits.
As this causes a memory leak which can consume all of memory
the fix is suitable for -stable.
Reported-by: mdraid.pkoch at dfgh.net (Peter Koch)
Signed-off-by: NeilBrown <neilb at suse.de>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
drivers/md/raid10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 496a46e..4800e56 100644
@@ -4421,7 +4421,7 @@ read_more:
read_bio->bi_private = r10_bio;
read_bio->bi_end_io = end_sync_read;
read_bio->bi_rw = READ;
- read_bio->bi_flags &= ~(BIO_POOL_MASK - 1);
+ read_bio->bi_flags &= (~0UL << BIO_RESET_BITS);
read_bio->bi_flags |= 1 << BIO_UPTODATE;
read_bio->bi_vcnt = 0;
read_bio->bi_size = 0;
More information about the kernel-team