[PATCH 3.13 094/187] hpsa: fix bad -ENOMEM return value in hpsa_big_passthru_ioctl

Kamal Mostafa kamal at canonical.com
Mon Sep 15 22:08:24 UTC 2014


3.13.11.7 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: "Stephen M. Cameron" <scameron at beardog.cce.hp.com>

commit 0758f4f732b08b6ef07f2e5f735655cf69fea477 upstream.

When copy_from_user fails, return -EFAULT, not -ENOMEM

Signed-off-by: Stephen M. Cameron <scameron at beardog.cce.hp.com>
Reported-by: Robert Elliott <elliott at hp.com>
Reviewed-by: Joe Handzik <joseph.t.handzik at hp.com>
Reviewed-by: Scott Teel <scott.teel at hp.com>
Reviewed by: Mike MIller <michael.miller at canonical.com>
Signed-off-by: Christoph Hellwig <hch at lst.de>

Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 drivers/scsi/hpsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index ad034ab..d518bba 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3151,7 +3151,7 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info *h, void __user *argp)
 		}
 		if (ioc->Request.Type.Direction == XFER_WRITE) {
 			if (copy_from_user(buff[sg_used], data_ptr, sz)) {
-				status = -ENOMEM;
+				status = -EFAULT;
 				goto cleanup1;
 			}
 		} else
-- 
1.9.1





More information about the kernel-team mailing list