[PATCH 3.13 037/163] drm/radeon: fix semaphore value init

Kamal Mostafa kamal at canonical.com
Thu Oct 9 21:01:02 UTC 2014 -stable review patch.  If anyone has any objections, please let me know.


From: =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig at amd.com>

commit f229407da79315c18a2f25f485e1a1b9fdda1e92 upstream.

Semaphore values have 64 bits, not 32. This fixes a very subtle bug
that disables synchronization when the upper 32bits wasn't zero.

Signed-off-by: Christian K├Ânig <christian.koenig at amd.com>
Reviewed-By: Grigori Goronzy <greg at chown.ath.cx>
Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
 drivers/gpu/drm/radeon/radeon_semaphore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_semaphore.c b/drivers/gpu/drm/radeon/radeon_semaphore.c
index 9006b32..eb7b600 100644
--- a/drivers/gpu/drm/radeon/radeon_semaphore.c
+++ b/drivers/gpu/drm/radeon/radeon_semaphore.c
@@ -34,7 +34,7 @@
 int radeon_semaphore_create(struct radeon_device *rdev,
 			    struct radeon_semaphore **semaphore)
-	uint32_t *cpu_addr;
+	uint64_t *cpu_addr;
 	int i, r;
 	*semaphore = kmalloc(sizeof(struct radeon_semaphore), GFP_KERNEL);

More information about the kernel-team mailing list