[PATCH 3.13 029/163] usb: dwc3: omap: fix ordering for runtime pm calls

Kamal Mostafa kamal at canonical.com
Thu Oct 9 21:00:54 UTC 2014 -stable review patch.  If anyone has any objections, please let me know.


From: Felipe Balbi <balbi at ti.com>

commit 81a60b7f5c143ab3cdcd9943c9b4b7c63c32fc31 upstream.

we don't to gate clocks until our children are
done with their remove path.

Fixes: af310e9 (usb: dwc3: omap: use runtime API's to enable clocks)
Signed-off-by: Felipe Balbi <balbi at ti.com>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
 drivers/usb/dwc3/dwc3-omap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 7f7ea62..2a0422b 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -592,9 +592,9 @@ static int dwc3_omap_remove(struct platform_device *pdev)
 	if (omap->extcon_id_dev.edev)
+	device_for_each_child(&pdev->dev, NULL, dwc3_omap_remove_core);
-	device_for_each_child(&pdev->dev, NULL, dwc3_omap_remove_core);
 	return 0;

More information about the kernel-team mailing list