[3.13.y.z extended stable] Patch "ACPI / RTC: Fix CMOS RTC opregion handler accesses to wrong addresses" has been added to staging queue

Kamal Mostafa kamal at canonical.com
Wed Oct 8 22:14:05 UTC 2014

This is a note to let you know that I have just added a patch titled

    ACPI / RTC: Fix CMOS RTC opregion handler accesses to wrong addresses

to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree 
which can be found at:


This patch is scheduled to be released in version

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.13.y.z tree, see



>From 01f226e3f18162c6a07bbcfee64488fd6a320a5b Mon Sep 17 00:00:00 2001
From: "Lee, Chun-Yi" <joeyli.kernel at gmail.com>
Date: Thu, 4 Sep 2014 15:13:39 +0800
Subject: ACPI / RTC: Fix CMOS RTC opregion handler accesses to wrong addresses

commit 9389f46e9782ea5e56fbd7b2e59ba7c08f3ba86b upstream.

The value64 parameter is an u64 point that used to transfer the value
for write to CMOS, or used to return the value that's read from CMOS.

The value64 is an u64 point, so don't need get address again. It causes
acpi_cmos_rtc_space_handler always return 0 to reader and didn't write
expected value to CMOS.

Signed-off-by: Lee, Chun-Yi <jlee at suse.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
 drivers/acpi/acpi_cmos_rtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpi_cmos_rtc.c b/drivers/acpi/acpi_cmos_rtc.c
index 84190ed..aff69d9 100644
--- a/drivers/acpi/acpi_cmos_rtc.c
+++ b/drivers/acpi/acpi_cmos_rtc.c
@@ -35,7 +35,7 @@ acpi_cmos_rtc_space_handler(u32 function, acpi_physical_address address,
 		      void *handler_context, void *region_context)
 	int i;
-	u8 *value = (u8 *)&value64;
+	u8 *value = (u8 *)value64;

 	if (address > 0xff || !value64)

More information about the kernel-team mailing list