[Acked] [Trusty][PATCH 1/5] iwlwifi: 7000: bump firmware API version to 9

Andy Whitcroft apw at canonical.com
Wed Nov 26 10:38:38 UTC 2014


On Tue, Nov 25, 2014 at 05:29:25PM -0600, Seth Forshee wrote:
> On Fri, Nov 21, 2014 at 04:16:10PM +0800, Adam Lee wrote:
> > From: Emmanuel Grumbach <emmanuel.grumbach at intel.com>
> > 
> > BugLink: https://bugs.launchpad.net/bugs/1393317
> > 
> > Also warn if an older firmware is loaded.
> > 
> > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach at intel.com>
> > (back ported from commit f0d5bb07a3765e086e6ff5e397b13616e6883d04)
> > Signed-off-by: Adam Lee <adam.lee at canonical.com>
> > 
> > Conflicts:
> > 	drivers/net/wireless/iwlwifi/iwl-7000.c
> 
> Tested with 3160 / 7260 / 7265 against several AP models and I didn't
> find any regressions. I did notice a problem with the 7265 when used
> with one of the APs if power save was enabled, but after comapring with
> various combinations of -8 and -9 ucode and kernels this doesn't seem to
> be a regression.
> 
> The "extra" patches to make the WIPHY_FLAG_SUPPORTS_SCHED_SCAN match
> upstream looks fine. It's quite a few patches for what is ultimately a
> small change, but all are clean upstream cherry-picks. So for the whole
> series:
> 
> Acked-by: Seth Forshee <seth.forshee at canonical.com>

Ok, I concur with your analysis, the first is pretty simple, the others
which mostly only trigger with firmware 10 are ok in the sense they make
things match upstream.  We will need to retest well when -10 comes to
linux-firmware.

Based on the testing as much as anything:

Acked-by: Andy Whitcroft <apw at canonical.com>

-apw




More information about the kernel-team mailing list