[PATCH 07/13] arch/powerpc/platforms/powernv/opal-elog.c: fix world-writable sysfs files

tim.gardner at canonical.com tim.gardner at canonical.com
Thu Nov 20 17:01:51 UTC 2014


From: Rusty Russell <rusty at rustcorp.com.au>

BugLink: http://bugs.launchpad.net/bugs/1391953

If you don't have a store function, you're not writable anyway!

Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Acked-by: Stewart Smith <stewart at linux.vnet.ibm.com>
Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
---
 arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c
index feb47b9..518fe95 100644
--- a/arch/powerpc/platforms/powernv/opal-elog.c
+++ b/arch/powerpc/platforms/powernv/opal-elog.c
@@ -82,9 +82,9 @@ static ssize_t elog_ack_store(struct elog_obj *elog_obj,
 }
 
 static struct elog_attribute id_attribute =
-	__ATTR(id, 0666, elog_id_show, NULL);
+	__ATTR(id, S_IRUGO, elog_id_show, NULL);
 static struct elog_attribute type_attribute =
-	__ATTR(type, 0666, elog_type_show, NULL);
+	__ATTR(type, S_IRUGO, elog_type_show, NULL);
 static struct elog_attribute ack_attribute =
 	__ATTR(acknowledge, 0660, elog_ack_show, elog_ack_store);
 
-- 
2.1.3





More information about the kernel-team mailing list