[Acked/cmt] [PATCH] HID: Add the transport-driver functions to the HIDP driver.

Andy Whitcroft apw at canonical.com
Tue Nov 18 16:06:45 UTC 2014


On Tue, Nov 18, 2014 at 09:04:37PM +0800, Keng-Yu Lin wrote:
> From: Frank Praznik <frank.praznik at oh.rr.com>
> 
> Add raw_request, set_raw_report and output_report transport-driver functions to
> the HIDP driver.
> 
> Signed-off-by: Frank Praznik <frank.praznik at oh.rr.com>
> Acked-by: David Herrmann <dh.herrmann at gmail.com>
> Signed-off-by: Jiri Kosina <jkosina at suse.cz>
> Signed-off-by: Keng-Yu Lin <kegnyu at canonical.com>
> Tested-By: Keng-Yu Lin <kengyu at canonical.com>
> Tested-By: Gerald Yang <gerald.yang at canonical.com>
> ---
>  net/bluetooth/hidp/core.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 90 insertions(+)

Ok, this has no upstream provenance, I assume from a search of linus'
tree that this is the following commit:

  commit 0a7f364e812285246cd617a51194a3f8bd0e8daa
  Author: Frank Praznik <frank.praznik at oh.rr.com>
  Date:   Wed Jan 22 13:49:44 2014 -0500

    HID: Add the transport-driver functions to the HIDP driver.

Indeed this commit seems to be cherry-pickable.  Please when submitting
patches include this information (git cherry-pick -sx is your friend), it
is _very_ important for tracking CVEs and the like later in the kernel's
life.  Also the patch itself is missing the BugLink: which just makes
work for the person applying this later on, and risks it becoming missed.

For other reviewers, this patch does appear to need a foundational commit,
which would normally not be in trusty but for other fixes has already
been applied.  Lastly this fix was applied in v3.15-rc1 and therefore is
not required in either Utopic or Vivid.

Assuming this is confirmed as the implied cherry-pick of the above sha1,
then: 

Acked-by: Andy Whitcroft <apw at canonical.com>

-apw




More information about the kernel-team mailing list