[PULL][Trusty/Utopic] xgene-enet 10G & SGMII 1G support

Dann Frazier dann.frazier at canonical.com
Mon Nov 17 18:12:58 UTC 2014


On Mon, Nov 17, 2014 at 4:54 AM, Andy Whitcroft <apw at canonical.com> wrote:
> On Sun, Nov 16, 2014 at 09:26:25PM -0700, Dann Frazier wrote:
>> These backports for the xgene-enet driver enable 10G support and SGMII
>> 1G support, addressing the following issues:
>>   http://bugs.launchpad.net/bugs/1381084
>>   http://bugs.launchpad.net/bugs/1381216
>>
>> Trusty
>>   git://kernel.ubuntu.com/dannf/trusty-xgene.git@xgene-enet-10GbE+SGMII
>> Utopic:
>>   git://kernel.ubuntu.com/dannf/ubuntu-utopic-hyperscale.git@xgene-enet-10GbE+SGMII
>
>
> Gads, these are large patch sets.  At least these are (almost for trusty
> and completely for utopic) self contained in the xgene code so regression
> potential for any other platform is limited.  Overall the non-xgene code
> looks pretty safe.
>
> In your trusty stack you have (at least) this commit which is marked as a
> cherry-pick but lists conflicts, those should be 'backported from <sha>'
> for clarity:
>
>   commit aa3083f7e3cb27cf05abc7d97edb58515571ccf8
>   Author: Iyappan Subramanian <isubramanian at apm.com>
>   Date:   Mon Oct 13 17:05:32 2014 -0700
>
>     dtb: Add SGMII based 1GbE node to APM X-Gene SoC device tree
>
> There look to be similar ones in both trees.

Yeah - backports are the same for both, except that trusty required 2
(1.5?) base patches.

> Overall they seem to be large, but well contained so I would be inclined
> to take them, with those commits fixed up.

Commits reworded - pushed over the same branch. Thanks for the review!

> -apw




More information about the kernel-team mailing list