[Trusty][PATCH] iwlwifi: 7000: bump firmware API version to 9
Andy Whitcroft
apw at canonical.com
Mon Nov 17 10:39:54 UTC 2014
On Mon, Nov 17, 2014 at 04:34:58PM +0800, Adam Lee wrote:
> From: Emmanuel Grumbach <emmanuel.grumbach at intel.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1393317
>
> Also warn if an older firmware is loaded.
>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach at intel.com>
> (back ported from commit f0d5bb07a3765e086e6ff5e397b13616e6883d04)
> Signed-off-by: Adam Lee <adam.lee at canonical.com>
>
> Conflicts:
> drivers/net/wireless/iwlwifi/iwl-7000.c
> ---
> drivers/net/wireless/iwlwifi/iwl-7000.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-7000.c b/drivers/net/wireless/iwlwifi/iwl-7000.c
> index ee02c3b..c3dc880 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-7000.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-7000.c
> @@ -67,12 +67,12 @@
> #include "iwl-agn-hw.h"
>
> /* Highest firmware API version supported */
> -#define IWL7260_UCODE_API_MAX 8
> -#define IWL3160_UCODE_API_MAX 8
> +#define IWL7260_UCODE_API_MAX 9
> +#define IWL3160_UCODE_API_MAX 9
>
> /* Oldest version we won't warn about */
> -#define IWL7260_UCODE_API_OK 7
> -#define IWL3160_UCODE_API_OK 7
> +#define IWL7260_UCODE_API_OK 9
> +#define IWL3160_UCODE_API_OK 9
>
> /* Lowest firmware API version supported */
> #define IWL7260_UCODE_API_MIN 7
This is really a request to up the firmware for all of these. What
bredth of testing has been done on the adapters which use these. Is
this firmware already in vivid, and is it in use there? We have had a
number of regressions from firmware updates in the past, and need to
ensure we test this well.
It would also be helpful to include a potted history of why this is
needed and how many people are affected rather than relying on my
reading the bug.
-apw
More information about the kernel-team
mailing list