NAK: [Trusty] UBUNTU: SAUCE: (no-up) Bluetooth: HIDP: Add back missing HID operations

[Seth Forshee]

On Fri, Nov 14, 2014 at 08:40:00PM +0800, Keng-Yu Lin wrote:
> Due to a previous patch, hid_device no longer has hid_get_raw_report()
> in its struct.
> 
>     commit aa6c390c4d59c9ff4fffd887e15783b2b793951b
>     Author: Benjamin Tissoires <benjamin.tissoires at redhat.com>
>     Date:   Wed Feb 5 16:33:22 2014 -0500
> 
>         HID: remove hid_get_raw_report in struct hid_device
> 
>         BugLink: http://bugs.launchpad.net/bugs/1305522
> 
>         dev->hid_get_raw_report(X) and hid_hw_raw_request(X, HID_REQ_GET_REPORT)
>         are strictly equivalent. Switch the hid subsystem to the hid_hw notation
>         and remove the field .hid_get_raw_report in struct hid_device.
> 
>         Reviewed-by: David Herrmann <dh.herrmann at gmail.com>
>         Signed-off-by: Benjamin Tissoires <benjamin.tissoires at redhat.com>
>         Signed-off-by: Jiri Kosina <jkosina at suse.cz>
>         (cherry picked from commit cafebc058bf86e63fff5354864781d3de11e41d3)
>         Acked-by: Brad Figg <brad.figg at canonical.com>
>         Signed-off-by: Chia-Lin Kao <acelan.kao at canonical.com>
>         Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> 
> And the net/bluetooth/hidp/core.c in Trusty tree has some mysterious changes
> (I could not trace them back with git blame)
> such as no .raw_request assignment in struct hid_ll_driver.
> This broke things such as the battery strenth in hid-input.c.
> 
> This patch added back the missing HID operations and copied the necessary
> code snippet from mainline.
> 
> The patch was tested on my Lenovo Thinkpad X240 and HP K4000 Bluetooth
> keyboard.
> 
> Signed-off-by: Keng-Yu Lin <kengyu at canonical.com>

A few problems here. First off, there's not bug link here and no SRU
justification.

Second, it looks like raw_request was never present in hid_ll_driver in
trusty's kernel. It was added during 3.15 by
0a7f364e812285246cd617a51194a3f8bd0e8daa "HID: Add the transport-driver
functions to the HIDP driver." So it seems impossible for its "removal"
to have broken anything.

What it looks really happened is that some prerequisite patches were
missed when the Synaptics hid driver was backported, and now you've kind
of squashed those together into a single patch. It would be better if
you would backport the original upstream commits individually, or if
that isn't practical at least reference then in your commit message.

Thanks,
Seth