[PATCH 3.13 110/162] iio: mxs-lradc: Propagate the real error code on platform_get_irq() failure

Kamal Mostafa kamal at canonical.com
Thu Nov 6 22:36:14 UTC 2014


3.13.11.11 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: Fabio Estevam <fabio.estevam at freescale.com>

commit 9610e08e97370ca7780bea977b03355fa0261635 upstream.

No need to return a 'fake' return value on platform_get_irq() failure.

Just return the error code itself instead.

Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
Acked-by: Marek Vasut <marex at denx.de>
Signed-off-by: Jonathan Cameron <jic23 at kernel.org>
[ kamal: 3.13-stable prereq for
  75d7ed3 iio: adc: mxs-lradc: Disable the clock on probe failure ]
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 drivers/staging/iio/adc/mxs-lradc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
index 558a76c..cef5dde 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -1308,7 +1308,7 @@ static int mxs_lradc_probe(struct platform_device *pdev)
 	for (i = 0; i < of_cfg->irq_count; i++) {
 		lradc->irq[i] = platform_get_irq(pdev, i);
 		if (lradc->irq[i] < 0)
-			return -EINVAL;
+			return lradc->irq[i];
 
 		ret = devm_request_irq(dev, lradc->irq[i],
 					mxs_lradc_handle_irq, 0,
-- 
1.9.1





More information about the kernel-team mailing list