[PATCH 02/18] drm: fix memory leak around mode_group (v2)

Dariusz Gadomski dariusz.gadomski at canonical.com
Mon Nov 3 14:04:04 UTC 2014


On Mon, Nov 03, 2014 at 01:34:40PM +0000, Luis Henriques wrote:
> I haven't reviewed this patchset but you need to either fix this one
> or drop it from the set as it doesn't seem to be relevant :-)

That's a good point. I've missed that. In fact this is not
necessary here.

> 
> Oh, and the SHA1s don't seem to exists upstream.

As I have mentioned in the cover letter this has been initially
backported to v3.16 by David Airlie - the original author of this
feature
(http://cgit.freedesktop.org/~airlied/linux/log/?h=drm-i915-mst-v3.16).
I have done the cherry-picking referring to his branch as the
'upstream'.

For some reason he kept the commit there
(http://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-i915-mst-v3.16&id=04a2b20670b9c24e69497ff5315f3d28955c8284)
As you have noted - it is totally unnecessary in this context.

Cheers,
Dariusz




More information about the kernel-team mailing list