[3.11.y.z extended stable] Patch "hwmon: (emc1403) fix inverted store_hyst()" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Fri May 30 09:28:49 UTC 2014

This is a note to let you know that I have just added a patch titled

    hwmon: (emc1403) fix inverted store_hyst()

to the linux-3.11.y-queue branch of the 3.11.y.z extended stable tree 
which can be found at:


If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.11.y.z tree, see



>From 567e4a348ae2917f6f0e7bc6afa6b7a9e6c3f411 Mon Sep 17 00:00:00 2001
From: Josef Gajdusek <atx at atx.name>
Date: Sun, 11 May 2014 14:40:44 +0200
Subject: hwmon: (emc1403) fix inverted store_hyst()

commit 17c048fc4bd95efea208a1920f169547d8588f1f upstream.

Attempts to set the hysteresis value to a temperature below the target
limit fails with "write error: Numerical result out of range" due to
an inverted comparison.

Signed-off-by: Josef Gajdusek <atx at atx.name>
Reviewed-by: Jean Delvare <jdelvare at suse.de>
[Guenter Roeck: Updated headline and description]
Signed-off-by: Guenter Roeck <linux at roeck-us.net>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
 drivers/hwmon/emc1403.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
index 142e1cb8dea7..62fba71ef3c5 100644
--- a/drivers/hwmon/emc1403.c
+++ b/drivers/hwmon/emc1403.c
@@ -162,7 +162,7 @@ static ssize_t store_hyst(struct device *dev,
 	if (retval < 0)
 		goto fail;

-	hyst = val - retval * 1000;
+	hyst = retval * 1000 - val;
 	hyst = DIV_ROUND_CLOSEST(hyst, 1000);
 	if (hyst < 0 || hyst > 255) {
 		retval = -ERANGE;

More information about the kernel-team mailing list