[PATCH 3.11 08/70] locks: allow __break_lease to sleep even when break_time is 0

Luis Henriques luis.henriques at canonical.com
Wed May 7 13:12:11 UTC 2014 -stable review patch.  If anyone has any objections, please let me know.


From: Jeff Layton <jlayton at redhat.com>

commit f1c6bb2cb8b81013e8979806f8e15e3d53efb96d upstream.

A fl->fl_break_time of 0 has a special meaning to the lease break code
that basically means "never break the lease". knfsd uses this to ensure
that leases don't disappear out from under it.

Unfortunately, the code in __break_lease can end up passing this value
to wait_event_interruptible as a timeout, which prevents it from going
to sleep at all. This makes __break_lease to spin in a tight loop and
causes soft lockups.

Fix this by ensuring that we pass a minimum value of 1 as a timeout

Cc: J. Bruce Fields <bfields at fieldses.org>
Reported-by: Terry Barnaby <terry1 at beam.ltd.uk>
Signed-off-by: Jeff Layton <jlayton at redhat.com>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
 fs/locks.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/locks.c b/fs/locks.c
index b27a300..ad95fbd 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -1359,11 +1359,10 @@ int __break_lease(struct inode *inode, unsigned int mode)
 	break_time = flock->fl_break_time;
-	if (break_time != 0) {
+	if (break_time != 0)
 		break_time -= jiffies;
-		if (break_time == 0)
-			break_time++;
-	}
+	if (break_time == 0)
+		break_time++;
 	locks_insert_block(flock, new_fl);
 	error = wait_event_interruptible_timeout(new_fl->fl_wait,

More information about the kernel-team mailing list