Ack: [quantal][sru][PATCH v2] module: do percpu allocation after uniqueness check. No, really!

Seth Forshee seth.forshee at canonical.com
Fri Mar 28 18:18:08 UTC 2014


On Fri, Mar 28, 2014 at 10:47:26AM -0500, Chris J Arges wrote:
> From: Rusty Russell <rusty at rustcorp.com.au>
> 
> BugLink: http://bugs.launchpad.net/bugs/1088433
> 
> v3.8-rc1-5-g1fb9341 was supposed to stop parallel kvm loads exhausting
> percpu memory on large machines:
> 
>     Now we have a new state MODULE_STATE_UNFORMED, we can insert the
>     module into the list (and thus guarantee its uniqueness) before we
>     allocate the per-cpu region.
> 
> In my defence, it didn't actually say the patch did this.  Just that
> we "can".
> 
> This patch actually *does* it.
> 
> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
> Tested-by: Jim Hull <jim.hull at hp.com>
> Cc: stable at kernel.org # 3.8
> (backported from commit 8d8022e8aba85192e937f1f0f7450e256d66ae5c)
> 
> Signed-off-by: Chris J Arges <chris.j.arges at canonical.com>

The backport looks good to me.

Acked-by: Seth Forshee <seth.forshee at canonical.com>




More information about the kernel-team mailing list