[PATCH 0/4][trusty] iwlwifi: Support for collecting firmware state dumps on errors

[Seth Forshee]

On Thu, Mar 20, 2014 at 03:22:18PM +0000, Andy Whitcroft wrote:
> On Thu, Mar 20, 2014 at 10:02:55AM -0500, Seth Forshee wrote:
> > Intel has requested that we pick up a patch from wireless-next which
> > collects firmware state dumps to assist with debugging firmware errors.
> > What follows is a backport of the patch from 3.13 plus a few additional
> > improvements.
> > 
> > This is also going to require a udev rule to collect the dumps and
> > apport changes to attach them to bug reports, both of which I'm
> > currently working on.
> > 
> > Thanks,
> > Seth
> > 
> > 
> > Emmanuel Grumbach (1):
> >   UBUNTU: SAUCE: iwlwifi: mvm: send udev event upon firmware error to
> >     dump logs
> > 
> > Seth Forshee (3):
> >   UBUNTU: SAUCE: iwlwifi: mvm: Free sram dump immediately after using it
> >   UBUNTU: SAUCE: iwlwifi: mvm: Only notify userspace of fw error dump
> >     when one is created
> >   UBUNTU: SAUCE: iwlwifi: mvm: Don't create fw error dump if there's
> >     nothing to dump
> > 
> >  drivers/net/wireless/iwlwifi/mvm/debugfs.c       |  50 +++++++++++
> >  drivers/net/wireless/iwlwifi/mvm/fw-error-dump.h | 106 +++++++++++++++++++++++
> >  drivers/net/wireless/iwlwifi/mvm/mac80211.c      |   8 ++
> >  drivers/net/wireless/iwlwifi/mvm/mvm.h           |   8 +-
> >  drivers/net/wireless/iwlwifi/mvm/ops.c           |  61 ++++++++++++-
> >  drivers/net/wireless/iwlwifi/mvm/utils.c         |  21 +++--
> >  6 files changed, 240 insertions(+), 14 deletions(-)
> >  create mode 100644 drivers/net/wireless/iwlwifi/mvm/fw-error-dump.h
> 
> Although they seem large, the large majority of this code is in the
> error path.  Overall it looks valid.  Do we have any way to test this,
> ie to force a failure trigger?

echo 1 > /sys/kernel/debug/iwlwifi/<device>/iwlmvm/fw_restart

> 
> If this is going to help us debug these tricky iwlwifi firmware issues I
> am in favour.
> 
> -apw