[3.11.y.z extended stable] Patch "staging: comedi: drivers: fix return value of comedi_load_firmware()" has been added to staging queue
Luis Henriques
luis.henriques at canonical.com
Thu Jan 9 12:03:44 UTC 2014
This is a note to let you know that I have just added a patch titled
staging: comedi: drivers: fix return value of comedi_load_firmware()
to the linux-3.11.y-queue branch of the 3.11.y.z extended stable tree
which can be found at:
http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.11.y-queue
If you, or anyone else, feels it should not be added to this tree, please
reply to this email.
For more information about the 3.11.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
Thanks.
-Luis
------
>From 84b65da8447acbc551d1fb263cc7093d7d461545 Mon Sep 17 00:00:00 2001
From: H Hartley Sweeten <hsweeten at visionengravers.com>
Date: Tue, 10 Dec 2013 16:31:25 -0700
Subject: staging: comedi: drivers: fix return value of comedi_load_firmware()
commit c6236c0ce39c809c336ca929f68cf8ad02cf94e0 upstream.
Some of the callback functions that upload the firmware in the comedi
drivers return a positive value indicating the number of bytes sent
to the device. Detect this condition and just return '0' to indicate
a successful upload.
Reported-by: Bernd Porr <mail at berndporr.me.uk>
Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Acked-by: Ian Abbott <abbotti at mev.co.uk>
Acked-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
drivers/staging/comedi/drivers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index b3b5125..0ea7c93 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -365,7 +365,7 @@ int comedi_load_firmware(struct comedi_device *dev,
release_firmware(fw);
}
- return ret;
+ return ret < 0 ? ret : 0;
}
EXPORT_SYMBOL_GPL(comedi_load_firmware);
--
1.8.3.2
More information about the kernel-team
mailing list