[PATCH 00/12] SATA driver for APM X-Gene board

Andy Whitcroft apw at canonical.com
Tue Feb 25 11:42:00 UTC 2014


On Tue, Feb 25, 2014 at 05:22:09PM +0800, Ike Panhc wrote:
> The patchset is also available at
>   git://kernel.ubuntu.com/ikepanhc/public.git lp1282920
> 
> APM posted SATA driver from X-Gene on linux-ide ML and its based on
> several new API functions introduced for SUNXi SoCs by Hans de Goede
> and 5 more patches has been cherry-picked.
> 
> The SATA driver depends on PHY driver which is also cherry-picked.
> 
> There are two slight modifications to make it compile-able and work
>  * ahci_platform_put_resources must be exported
>  * new ahci_platform_put_resources need one more parameter which not used
> -	ahci_platform_put_resources(hpriv);
> +	ahci_platform_put_resources(pdev, hpriv);
> 
> Ref: http://www.spinics.net/lists/linux-ide/msg47953.html
>      http://www.spinics.net/lists/linux-ide/msg47944.html
> BugLink: https://bugs.launchpad.net/bugs/1282920
> 
> We have v13 patchset with only comment update and Tejun Heo has some
> feedback. I will update the driver once its available.
> 
> Hans de Goede (5):
>   libahci: Allow drivers to override start_engine
>   ahci-platform: Add support for devices with more then 1 clock
>   ahci-platform: Add support for an optional regulator for sata-target
>     power
>   ahci-platform: Add enable_ / disable_resources helper functions
>   ahci-platform: "Library-ise" ahci_probe functionality

Ugg, these affect the ahci code heavily, the changes look nicely done
and if they get upstream then they would be ok I guess but they are
large and complex.

We are going to need some good testing on existing ahci bits on the
results here.  Risk == high.

> 
> Ike Panhc (2):
>   UBUNTU: ahci-platform: export ahci_platform_put_resources
>   UBUNTU: [Config] Enable AHCI_XGENE and PHY_XGENE for arm64
> 
> Loc Ho (5):
>   PHY: Add function set_speed to generic PHY framework
>   PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver
>   arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries
>   ata: Add APM X-Gene SoC AHCI SATA host controller driver
>   arm64: Add APM X-Gene SoC AHCI SATA host controller DTS entries

The rest of this looks pretty self contained and low risk.

-apw




More information about the kernel-team mailing list