[3.11.y.z extended stable] Patch "ALSA: hda/realtek - Avoid invalid COEFs for ALC271X" has been added to staging queue

[Luis Henriques]

On Mon, Feb 17, 2014 at 10:14:36AM +0100, Takashi Iwai wrote:
> At Fri, 14 Feb 2014 10:11:14 +0000,
> Luis Henriques wrote:
> > 
> > This is a note to let you know that I have just added a patch titled
> > 
> >     ALSA: hda/realtek - Avoid invalid COEFs for ALC271X
> > 
> > to the linux-3.11.y-queue branch of the 3.11.y.z extended stable tree 
> > which can be found at:
> > 
> >  http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.11.y-queue
> > 
> > If you, or anyone else, feels it should not be added to this tree, please 
> > reply to this email.
> 
> Please drop this.  This commit was reverted due to a regression later
> by the upstream commit 2078600b1f8fc68b02f6ebdda1759fb0c9f51afb
>     ALSA: Revert "ALSA: hda/realtek - Avoid invalid COEFs for ALC271X"
> (which was already merged to Linus tree now).
>     
> 
> thanks,
> 
> Takashi
> 

Thank you, I'll drop this patch from the 3.5 and 3.11 kernels.

Cheers,
--
Luis

> 
> > 
> > For more information about the 3.11.y.z tree, see
> > https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
> > 
> > Thanks.
> > -Luis
> > 
> > ------
> > 
> > >From e4271996595cedb827d96d062159990479a360e1 Mon Sep 17 00:00:00 2001
> > From: Takashi Iwai <tiwai at suse.de>
> > Date: Mon, 3 Feb 2014 09:56:13 +0100
> > Subject: ALSA: hda/realtek - Avoid invalid COEFs for ALC271X
> > 
> > commit d3c56568f43807135f2c2a09582a69f809f0d8b7 upstream.
> > 
> > We've seen often problems after suspend/resume on Acer Aspire One
> > AO725 with ALC271X codec as reported in kernel bugzilla, and it turned
> > out that some COEFs doesn't work and triggers the codec communication
> > stall.
> > 
> > Since these magic COEF setups are specific to ALC269VB for some PLL
> > configurations, the machine works even without these manual
> > adjustment.  So, let's simply avoid applying them for ALC271X.
> > 
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=52181
> > Signed-off-by: Takashi Iwai <tiwai at suse.de>
> > Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
> > ---
> >  sound/pci/hda/patch_realtek.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index cd4cbad..fd4b270 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -3916,6 +3916,9 @@ static void alc269_fill_coef(struct hda_codec *codec)
> > 
> >  	if (spec->codec_variant != ALC269_TYPE_ALC269VB)
> >  		return;
> > +	/* ALC271X doesn't seem to support these COEFs (bko#52181) */
> > +	if (!strcmp(codec->chip_name, "ALC271X"))
> > +		return;
> > 
> >  	if ((alc_get_coef0(codec) & 0x00ff) < 0x015) {
> >  		alc_write_coef_idx(codec, 0xf, 0x960b);
> > --
> > 1.8.3.2
> >