[PATCH][Trusty] UBUNTU: SAUCE: Add use_native_backlight quirk for HP ProBook 6570b

Chris J Arges chris.j.arges at canonical.com
Thu Dec 11 14:22:52 UTC 2014


On 12/11/2014 02:32 AM, AceLan Kao wrote:
> BugLink: http://bugs.launchpad.net/bugs/1359010
>

Overall this seems like a reasonable thing to SRU; however it would be
very helpful if you update a few things.

1) Follow the SRU wiki: https://wiki.ubuntu.com/KernelTeam/KernelUpdates
And provide an SRU justification for this patch.
2) Provide a plan for placing this patch upstream.
3) Ensure that this issue is fixed in newer releases as well; I don't
seem a similar quirk in upstream, vivid, utopic, etc. Either explain why
it isn't needed, or provide this fix to those versions as well.

Thanks,
--chris j arges

> The ACPI video backlight interface is broken under WIN8 OSI,
> have to switch to use native backlight interface.
> 
> Signed-off-by: AceLan Kao <acelan.kao at canonical.com>
> ---
>  drivers/acpi/video.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index e858463..db1dccd 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -604,6 +604,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
>  		},
>  	},
> +	{
> +	.callback = video_set_use_native_backlight,
> +	.ident = "HP ProBook 6570b",
> +	.matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook 6570b"),
> +		},
> +	},
>  	{}
>  };
>  
> 




More information about the kernel-team mailing list