[3.13.y-ckt stable] Patch "mm: frontswap: invalidate expired data on a dup-store failure" has been added to staging queue
Kamal Mostafa
kamal at canonical.com
Tue Dec 9 21:03:38 UTC 2014
This is a note to let you know that I have just added a patch titled
mm: frontswap: invalidate expired data on a dup-store failure
to the linux-3.13.y-queue branch of the 3.13.y-ckt extended stable tree
which can be found at:
http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.13.y-queue
This patch is scheduled to be released in version 3.13.11-ckt13.
If you, or anyone else, feels it should not be added to this tree, please
reply to this email.
For more information about the 3.13.y-ckt tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
Thanks.
-Kamal
------
>From 2aef7caf2fd28e85305539fa8cda389c539ee53d Mon Sep 17 00:00:00 2001
From: Weijie Yang <weijie.yang at samsung.com>
Date: Tue, 2 Dec 2014 15:59:25 -0800
Subject: mm: frontswap: invalidate expired data on a dup-store failure
commit fb993fa1a2f669215fa03a09eed7848f2663e336 upstream.
If a frontswap dup-store failed, it should invalidate the expired page
in the backend, or it could trigger some data corruption issue.
Such as:
1. use zswap as the frontswap backend with writeback feature
2. store a swap page(version_1) to entry A, success
3. dup-store a newer page(version_2) to the same entry A, fail
4. use __swap_writepage() write version_2 page to swapfile, success
5. zswap do shrink, writeback version_1 page to swapfile
6. version_2 page is overwrited by version_1, data corrupt.
This patch fixes this issue by invalidating expired data immediately
when meet a dup-store failure.
Signed-off-by: Weijie Yang <weijie.yang at samsung.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk at oracle.com>
Cc: Seth Jennings <sjennings at variantweb.net>
Cc: Dan Streetman <ddstreet at ieee.org>
Cc: Minchan Kim <minchan at kernel.org>
Cc: Bob Liu <bob.liu at oracle.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
mm/frontswap.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/frontswap.c b/mm/frontswap.c
index 1b24bdc..a55036a 100644
--- a/mm/frontswap.c
+++ b/mm/frontswap.c
@@ -244,8 +244,10 @@ int __frontswap_store(struct page *page)
the (older) page from frontswap
*/
inc_frontswap_failed_stores();
- if (dup)
+ if (dup) {
__frontswap_clear(sis, offset);
+ frontswap_ops->invalidate_page(type, offset);
+ }
}
if (frontswap_writethrough_enabled)
/* report failure so swap also writes to swap device */
--
1.9.1
More information about the kernel-team
mailing list