[CVE-2014-9090] x86_64, traps: Stop using IST for #SS

John Johansen john.johansen at canonical.com
Mon Dec 8 13:02:16 UTC 2014


On 12/05/2014 05:47 AM, Luis Henriques wrote:
> Following this email I am sending for review the CVE-2014-9090 fix
> backports for both Lucid (2.6.32) and Precise (3.2.0).
> 
> I'm also CC'ing Debian mailing-lists, Moritz, Ben and Willy as these
> backports could be of interest both to Debian and to the 2.6.32 and
> 3.2 stable kernels.
> 
> Andy Lutomirski (1):
>   x86_64, traps: Stop using IST for #SS
> 
>  arch/x86/include/asm/page_32_types.h |  1 -
>  arch/x86/include/asm/page_64_types.h | 11 +++++------
>  arch/x86/kernel/dumpstack_64.c       |  1 -
>  arch/x86/kernel/entry_64.S           |  2 +-
>  arch/x86/kernel/traps.c              | 13 +------------
>  5 files changed, 7 insertions(+), 21 deletions(-)
> 
> 
So both the Lucid and Precise patches look good to me. Like Stefan I
noticed the missing define but it does not appear to be used by the
patch.

I have not worked my way through the list of patches that Willy
provided so I can't yet comment on which of any of them should
be included. But I think the additional two patches that Ben
pointed out

af726f21ed8a x86_64, traps: Fix the espfix64 #DF fixup and rewrite it in C
b645af2d5905 x86_64, traps: Rework bad_iret

really should go with this

Acked-by: John Johansen <john.johansen at canonical.com>





More information about the kernel-team mailing list