ACK: [pull-request][utopic SRU] iwlwifi: Backport firmware monitor support

[Stefan Bader]

On 04.12.2014 23:05, Seth Forshee wrote:
> These patches were backported from 3.17 by Intel to help with debugging
> firmware issues [1]. They aren't suitable for upstream stable, but Intel
> wireless is widely used among Ubuntu users so I think it makes sense for
> us to pick them up if it's going to help get firmware bugs fixed.
> 
> The firmware monitor support is disabled be default and enabled only
> when the fw_monitor=1 option is given to iwlwifi. I have reviewed the
> patches, and I believe they have low potential for regression,
> especially without the module option. I also saw no regressions during
> testing, with or without the module option.
> 
> BugLink: http://bugs.launchpad.net/bugs/1399440
> 
> Thanks,
> Seth
> 
> [1] http://permalink.gmane.org/gmane.linux.kernel.wireless.general/129744
> 
> ---
> 
> The following changes since commit b9651a5d8545cd9c3072178d3540538af5948962:
> 
>   xen-netfront: Remove BUGs on paged skb data which crosses a page boundary (2014-12-04 10:04:17 -0800)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/sforshee/ubuntu-utopic.git lp1399440
> 
> for you to fetch changes up to 479b0e0368882c6e9e4c032efde277a4422a90f8:
> 
>   iwlwifi: mvm: update layout of firmware error dump (2014-12-04 15:50:34 -0600)
> 
> ----------------------------------------------------------------
> Emmanuel Grumbach (7):
>       iwlwifi: add device / firmware to fw-error-dump file
>       iwlwifi: rename iwl_mvm_fw_error_next_data
>       iwlwifi: pcie: add firmware monitor capabilities
>       iwlwifi: remove wrong comment about alignment in iwl-fw-error-dump.h
>       iwlwifi: mvm: don't collect logs in the interrupt thread
>       iwlwifi: mvm: kill iwl_mvm_fw_error_rxf_dump
>       iwlwifi: mvm: update layout of firmware error dump
> 
>  drivers/net/wireless/iwlwifi/iwl-drv.c           |   6 +++++
>  drivers/net/wireless/iwlwifi/iwl-fw-error-dump.h |  50 +++++++++++++++++++++++++++++++---
>  drivers/net/wireless/iwlwifi/iwl-fw-file.h       |   5 ++--
>  drivers/net/wireless/iwlwifi/iwl-fw.h            |   3 +++
>  drivers/net/wireless/iwlwifi/iwl-modparams.h     |   2 ++
>  drivers/net/wireless/iwlwifi/iwl-prph.h          |   6 +++++
>  drivers/net/wireless/iwlwifi/mvm/mac80211.c      | 100 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/net/wireless/iwlwifi/mvm/mvm.h           |   9 -------
>  drivers/net/wireless/iwlwifi/mvm/ops.c           |  72 -------------------------------------------------
>  drivers/net/wireless/iwlwifi/mvm/utils.c         |  65 --------------------------------------------
>  drivers/net/wireless/iwlwifi/pcie/internal.h     |   7 +++++
>  drivers/net/wireless/iwlwifi/pcie/trans.c        | 125 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  12 files changed, 294 insertions(+), 156 deletions(-)
> 
> 
Agreed that this looks rather large but given this is in collaboration with the
maintainer and well contained and the actual feature backported is disabled by
default, it feels acceptable.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20141208/49bd82c3/attachment.sig>