Fwd: Re: [REVERT][v3.16-rc7][STABLE] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

Wed Aug 13 19:09:34 UTC 2014

On 08/13/2014 02:48 PM, Tim Gardner wrote:
> On 07/30/2014 09:23 PM, Joseph Salisbury wrote:
>> On 07/30/2014 09:08 PM, Joseph Salisbury wrote:
>>> It looks like a new patch is available, so a revert may not be needed. 
>>>
>>> I'll build a test kernel and have it tried out.
>>>
>>>
>>> -------- Original Message --------
>>> Return-Path: 	<jwerner at google.com>
>>> X-Original-To: 	jsalisbury at mail.canonical.com
>>> Delivered-To: 	jsalisbury at mail.canonical.com
>>> Received: 	from fiordland.canonical.com (fiordland.canonical.com
>>> [91.189.94.145]) by grenadilla.canonical.com (Postfix) with ESMTP id
>>> 795841472109 for <jsalisbury at mail.canonical.com>; Wed, 30 Jul 2014
>>> 22:42:30 +0000 (UTC)
>>> Received: 	from cluster-e.mailcontrol.com (cluster-e.mailcontrol.com
>>> [85.115.58.190]) by fiordland.canonical.com (Postfix) with ESMTPS id
>>> ADF5DA1842F for <joseph.salisbury at cleanmail.canonical.com>; Wed, 30 Jul
>>> 2014 22:42:29 +0000 (UTC)
>>> Received: 	from arctowski.canonical.com (arctowski.canonical.com
>>> [91.189.94.158]) by rly08e.srv.mailcontrol.com (MailControl) with ESMTP
>>> id s6UMgSIk022206 for <joseph.salisbury at cleanmail.canonical.com>; Wed,
>>> 30 Jul 2014 23:42:28 +0100
>>> Received: 	from fiordland.canonical.com ([91.189.94.145]) by
>>> arctowski.canonical.com with esmtp (Exim 4.71) (envelope-from
>>> <jwerner at google.com>) id 1XCcZo-00088Z-J7 for
>>> joseph.salisbury at cleanmail.canonical.com; Wed, 30 Jul 2014 22:42:28 +0000
>>> Received: 	from mail-ob0-f172.google.com (mail-ob0-f172.google.com
>>> [209.85.214.172]) by fiordland.canonical.com (Postfix) with ESMTPS id
>>> 3B7D0A185C8 for <joseph.salisbury at canonical.com>; Wed, 30 Jul 2014
>>> 22:42:28 +0000 (UTC)
>>> Received: 	by mail-ob0-f172.google.com with SMTP id wn1so1026371obc.17
>>> for <joseph.salisbury at canonical.com>; Wed, 30 Jul 2014 15:42:27 -0700 (PDT)
>>> DKIM-Signature: 	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
>>> s=20120113;
>>> h=mime-version:sender:in-reply-to:references:date:message-id:subject
>>> :from:to:cc:content-type;
>>> bh=F9vRbSFkw1YkRChHEewlSr+iDr3a3upC0fn6ByYHmes=;
>>> b=mUogmC+yunRoFobYZnY0cxjF28sbaei1rhfSp0lFafpQY0DTiDOfWYT2l/MXWQ3qS6
>>> TZi1ReCubKyl6he5CzW5/PeTnlsAh6LwqkmaQlWdOWmHAKAwZ3UvfR5OPTn+GfI+Yxv+
>>> vl5mcraiTnWDt/CE7dWowkOLk01MI63pmi8YXGF4nLZVDOz1yM56F0lrdgzW6sNpnI4f
>>> 3vr7NFtSLYtPPhG4pp0P8weaQSFZp+5LJgRuuCQaqLT9uEn1S+upVjmxryIm2E29ifub
>>> jCbbInvksgi2RwSS12X9hSuW8x9cMGQBOtglAgPwCwKcWM4l0QD/NwNkxqcjzDedIkAO sv0A==
>>> DKIM-Signature: 	v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;
>>> s=google;
>>> h=mime-version:sender:in-reply-to:references:date:message-id:subject
>>> :from:to:cc:content-type;
>>> bh=F9vRbSFkw1YkRChHEewlSr+iDr3a3upC0fn6ByYHmes=;
>>> b=cOpqYzfuEB2LC31skKYQZ9eNrE+Qb6vq0nRITLiOxz+dR//Url9AZdSrOHJ4qCiEka
>>> 6h75ZQGBYfk+OPtef0SZCBzpB8Ev6/tqt21eR28sOgCXbbG8JOp93uaQKQTb846COPK7
>>> rs2gz/4AQ7iCF/1NXLdPOqg3m97DmPoQWfo4U=
>>> X-Google-DKIM-Signature: 	v=1; a=rsa-sha256; c=relaxed/relaxed;
>>> d=1e100.net; s=20130820;
>>> h=x-gm-message-state:mime-version:sender:in-reply-to:references:date
>>> :message-id:subject:from:to:cc:content-type;
>>> bh=F9vRbSFkw1YkRChHEewlSr+iDr3a3upC0fn6ByYHmes=;
>>> b=j+jvieKu3nEVmieyr39351XfWsgjJOh3rr5lZ3EGv5QFDccNmjfaoiiBDIheLtk149
>>> o5qoDL2Q5El1c4YI8hzTWwISiDD5rvQyCd0CfqTQ6isw3n+jyzWztOINkcM49Z4Z/usv
>>> O9j24xcFl/YvPFY/yIRzFsjCWuEK8ZMmQqO7V3Dpk4yI2oszUbdgwrPLUnOt4QUxZfkN
>>> nmFMiQf3YmImu9bb64Hw0nACBuJzYCfPEVjXTYbLSL8SB7n5+25YAgacwiwkhFkQ1YM6
>>> 6NsEAPj1ZjRwTMPj7L5ywDW7tbXAwOSWMNPg3hbpXMk44LCsByDAqaSQgO+pN/g5jSJn RZBA==
>>> X-Gm-Message-State:
>>> ALoCoQny33jWokbIkT7WY565pn0ovRC6/I1BUBLaUzciC2mzyVI6zLAbdLotQiQxT09UYTaQXIDe
>>>
>>> MIME-Version: 	1.0
>>> X-Received: 	by 10.182.236.162 with SMTP id
>>> uv2mr121521obc.12.1406760147164; Wed, 30 Jul 2014 15:42:27 -0700 (PDT)
>>> Sender: 	jwerner at google.com
>>> Received: 	by 10.182.98.102 with HTTP; Wed, 30 Jul 2014 15:42:27 -0700
>>> (PDT)
>>> In-Reply-To: 	<53D947F3.6010301 at canonical.com>
>>> References: 	<53D947F3.6010301 at canonical.com>
>>> Date: 	Wed, 30 Jul 2014 15:42:27 -0700
>>> X-Google-Sender-Auth: 	0hlZ83peSTzVaMJNr9XeMEHnOHs
>>> Message-ID:
>>> <CAODwPW-tf0D70v5La1z+-jo5rgKFW_Q2fMCZGWZkf0DnyTUuTA at mail.gmail.com>
>>> Subject: 	Re: [REVERT][v3.16-rc7][STABLE] usb: xhci: Prefer endpoint
>>> context dequeue pointer over stopped_trb
>>> From: 	Julius Werner <jwerner at chromium.org>
>>> To: 	Joseph Salisbury <joseph.salisbury at canonical.com>
>>> Cc: 	LKML <linux-kernel at vger.kernel.org>, "stable at vger.kernel.org"
>>> <stable at vger.kernel.org>, Julius Werner <jwerner at chromium.org>,
>>> "mathias.nyman at linux.intel.com" <mathias.nyman at linux.intel.com>, Greg KH
>>> <gregkh at linuxfoundation.org>, Dustin Kirkland
>>> <dustin.kirkland at canonical.com>
>>> Content-Type: 	text/plain; charset=UTF-8
>>> X-Mailcontrol-Inbound:
>>> WBq!ucXEz80wFmxD6S7f3nyjenN!phNbIQWiyBG44+lo3FL0yiLKb3yjenN!phNbh+9WRKrdgbE=
>>>
>>> X-Spam-Score: 	-0.651
>>> X-Scanned-By: 	MailControl 30291.32 (www.mailcontrol.com) on 10.69.0.118
>>>
>>>
>>>
>>> Hi Joseph,
>>>
>>>> Julius, I was hoping to get your feedback, since you are the patch
>>>> author.  Do you think gathering any additional data will help diagnose
>>>> this issue, or would it be best to continue with this revert request?
>>> As I understand it, this crash will disappear with Mathias' new rework
>>> for finding the cycle state bit in
>>> http://www.spinics.net/lists/linux-usb/msg111259.html , so a revert
>>> should not be necessary.
>>>
>>>
>>>
>>>
>> The patch builds against 3.16, but it does not build against 3.13.y or
>> Trusty.  I'll ping upstream for further details.
>>
> Any movement on this ?
>

I was unable to build the patch against 3.13 upstream.  I pined upstream
but have not gotten a response as of yet.  I'll ping them again, and see
if I can figure out the build failure to suggest a fix.

I'll send an update.