[PATCH 3.11 180/182] ipmi: Reset the KCS timeout when starting error recovery
Luis Henriques
luis.henriques at canonical.com
Thu Apr 24 08:51:45 UTC 2014
3.11.10.9 -stable review patch. If anyone has any objections, please let me know.
------------------
From: Corey Minyard <cminyard at mvista.com>
commit eb6d78ec213e6938559b801421d64714dafcf4b2 upstream.
The OBF timer in KCS was not reset in one situation when error recovery
was started, resulting in an immediate timeout.
Reported-by: Bodo Stroesser <bstroesser at ts.fujitsu.com>
Signed-off-by: Corey Minyard <cminyard at mvista.com>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
Cc: minyard at acm.org
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
drivers/char/ipmi/ipmi_kcs_sm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_kcs_sm.c b/drivers/char/ipmi/ipmi_kcs_sm.c
index e53fc24..e1ddcf9 100644
--- a/drivers/char/ipmi/ipmi_kcs_sm.c
+++ b/drivers/char/ipmi/ipmi_kcs_sm.c
@@ -251,8 +251,9 @@ static inline int check_obf(struct si_sm_data *kcs, unsigned char status,
if (!GET_STATUS_OBF(status)) {
kcs->obf_timeout -= time;
if (kcs->obf_timeout < 0) {
- start_error_recovery(kcs, "OBF not ready in time");
- return 1;
+ kcs->obf_timeout = OBF_RETRY_TIMEOUT;
+ start_error_recovery(kcs, "OBF not ready in time");
+ return 1;
}
return 0;
}
--
1.9.1
More information about the kernel-team
mailing list