[trusty] [PATCH 2/3] cpufreq: powernv: Use cpufreq_frequency_table.driver_data to store pstate ids

Seth Forshee seth.forshee at canonical.com
Fri Apr 18 14:38:27 UTC 2014


On Fri, Apr 18, 2014 at 09:36:45AM -0500, Seth Forshee wrote:
> On Fri, Apr 18, 2014 at 08:14:19AM -0600, Tim Gardner wrote:
> > On 04/18/2014 07:12 AM, Seth Forshee wrote:
> > >On Thu, Apr 17, 2014 at 12:37:00PM -0300, Mauricio Faria de Oliveira wrote:
> > >>From: "Gautham R. Shenoy" <ego at linux.vnet.ibm.com>
> > >>
> > >>The .driver_data field in the cpufreq_frequency_table was supposed to
> > >>be private to the drivers. However at some later point, it was being
> > >>used to indicate if the particular frequency in the table is the
> > >>BOOST_FREQUENCY. After patches [1] and [2], the .driver_data is once
> > >>again private to the driver. Thus we can safely use
> > >>cpufreq_frequency_table.driver_data to store pstate_ids instead of
> > >>having to maintain a separate array powernv_pstate_ids[] for this
> > >>purpose.
> > >>
> > >>[1]:
> > >>   Subject: cpufreq: don't print value of .driver_data from core
> > >>   From   : Viresh Kumar <viresh.kumar@ linaro.org>
> > >>   url    : http://marc.info/?l=linux-pm&m=139601421504709&w=2
> > >>
> > >>[2]:
> > >>   Subject: cpufreq: create another field .flags in cpufreq_frequency_table
> > >>   From   : Viresh Kumar <viresh.kumar at linaro.org>
> > >>   url    : http://marc.info/?l=linux-pm&m=139601416804702&w=2
> > >
> > >These two commits were merged by Linus in 3.15-rc1, and we don't have
> > >them in trusty. Aren't we going to need these too?
> > >
> > 
> > Though mentioned in the commit log, those 2 patches appear to be
> > independent. They were also merged afterwards, probably in a
> > parallel merge branch.
> > 
> > 7f4b04614a273089ad65654f53771c033fadc65e cpufreq: create another
> > field .flags in cpufreq_frequency_table
> > ae87f10f35f75deb8f74dbd92d062200932c2f26 cpufreq: don't print value
> > of .driver_data from core
> > 81f359027a3a383cc1dc79499ce97f1074861e5b cpufreq: powernv: Select
> > CPUFreq related Kconfig options for powernv
> > 0692c69138355fdbf32ecf70a2cde9c1fc3d7bb2 cpufreq: powernv: Use
> > cpufreq_frequency_table.driver_data to store pstate ids
> > b3d627a5f2bf1a9a486f65af6f7c2ce0e09b3d12 cpufreq: powernv: cpufreq
> > driver for powernv platform
> 
> Hmm, and also at second glance I guess neither of those patches actually
> affect anything which writes to driver_data. Furthermore it also appears
> that the "boost" code was added after 3.14, so those patches really

That should be after 3.13.

> aren't relevant to 3.13 anyway. Nevermind then.




More information about the kernel-team mailing list