[PATCH 3.11 22/46] vxlan: fix potential NULL dereference in arp_reduce()

Luis Henriques luis.henriques at canonical.com
Wed Apr 16 10:31:38 UTC 2014


3.11.10.8 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: David Stevens <dlstevens at us.ibm.com>

commit 7346135dcd3f9b57f30a5512094848c678d7143e upstream.

This patch fixes a NULL pointer dereference in the event of an
skb allocation failure in arp_reduce().

Signed-Off-By: David L Stevens <dlstevens at us.ibm.com>
Acked-by: Cong Wang <cwang at twopensource.com>

Signed-off-by: David S. Miller <davem at davemloft.net>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 drivers/net/vxlan.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 8a05d77..116810f 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -978,6 +978,9 @@ static int arp_reduce(struct net_device *dev, struct sk_buff *skb)
 
 		neigh_release(n);
 
+		if (reply == NULL)
+			goto out;
+
 		skb_reset_mac_header(reply);
 		__skb_pull(reply, skb_network_offset(reply));
 		reply->ip_summed = CHECKSUM_UNNECESSARY;
-- 
1.9.1





More information about the kernel-team mailing list