Ack: [PATCH 1/1] ACPI / video: Add systems that should favour native backlight interface

Seth Forshee seth.forshee at canonical.com
Mon Apr 7 11:25:25 UTC 2014


On Mon, Apr 07, 2014 at 11:50:08AM +0100, Andy Whitcroft wrote:
> From: Aaron Lu <aaron.lu at intel.com>
> 
> Some system's ACPI video backlight control interface is broken and the
> native backlight control interface should be used by default. This patch
> sets the use_native_backlight parameter to true for those systems so
> that video backlight control interface will not be created. For detailed
> models that are added here, reference the following list.
> 
> Note that the user specified kernel cmdline option will always have the
> highest priority, i.e. if use_native_backlight=0 is specified and the
> system is in the DMI table, the video module will not skip registering
> backlight interface for it.
> 
> Thinkpad T430s:
> Reported-by: Theodore Tso <tytso at mit.edu>
> Reported-and-tested-by: Peter Weber <bugs at ttyhoney.com>
> References: https://bugzilla.kernel.org/show_bug.cgi?id=51231
> Thinkpad X230:
> Reported-and-tested-by: Igor Gnatenko <i.gnatenko.brain at gmail.com>
> References: https://bugzilla.kernel.org/show_bug.cgi?id=51231
> ThinkPad X1 Carbon:
> Reported-and-tested-by: Igor Gnatenko <i.gnatenko.brain at gmail.com>
> Lenovo Yoga 13:
> Reported-by: Lennart Poettering <lennart at poettering.net>
> Reported-and-tested-by: Kevin Smith <thirdwiggin at gmail.com>
> References: https://bugzilla.kernel.org/show_bug.cgi?id=63811
> Dell Inspiron 7520:
> Reported-by: Rinat Ibragimov <ibragimovrinat at mail.ru>
> Acer Aspire 5733Z:
> Reported-by: <sov.info at mail.ru>
> References: https://bugzilla.kernel.org/show_bug.cgi?id=62941
> Acer Aspire V5-431:
> Reported-by: Thomas Christensen <christensenthomas at gmail.com>
> References: https://bugzilla.kernel.org/show_bug.cgi?id=68751
> HP ProBook 4340s:
> Reported-and-tested-by: Vladimir Sherenkov <a_12300 at mail.ru>
> References: http://redmine.russianfedora.pro/issues/1258
> HP EliteBook/ProBook 2013 models, ZBook and some others:
> Provided-by: Takashi Iwai <tiwai at suse.de>
> Signed-off-by: Aaron Lu <aaron.lu at intel.com>
> Tested-by: Mika Westerberg <mika.westerberg at linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
> 
> (backported from commit 0e9f81d3b7cd0649a3bc437391b6a0650f98f844)
> Conflicts:
> 	drivers/acpi/video_detect.c
> BugLink: http://bugs.launchpad.net/bugs/1158689
> Signed-off-by: Andy Whitcroft <apw at canonical.com>

Acked-by: Seth Forshee <seth.forshee at canonical.com>

We're also carrying ab2f48247d81e2432af6bc14ed213899f1133f61 and
0b23c20568280e2bbe599fef8f07ffd47457f31c which overlap with some of the
machines here. Most or all of those machines could likely be switched
over to quirks for use_native_backlight I suspect.

Seth




More information about the kernel-team mailing list