[PATCH 44/93] clk: wm831x: Initialise wm831x pointer on init

Kamal Mostafa kamal at canonical.com
Fri Sep 20 20:08:39 UTC 2013 -stable review patch.  If anyone has any objections, please let me know.


From: Mark Brown <broonie at linaro.org>

commit 08442ce993deeb15a070c14cc3f3459e87d111e0 upstream.

Otherwise any attempt to interact with the hardware will crash. This is
what happens when drivers get written blind.

Signed-off-by: Mark Brown <broonie at linaro.org>
Signed-off-by: Mike Turquette <mturquette at linaro.org>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
 drivers/clk/clk-wm831x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/clk-wm831x.c b/drivers/clk/clk-wm831x.c
index 16ed068..917a3ab 100644
--- a/drivers/clk/clk-wm831x.c
+++ b/drivers/clk/clk-wm831x.c
@@ -360,6 +360,8 @@ static int wm831x_clk_probe(struct platform_device *pdev)
 	if (!clkdata)
 		return -ENOMEM;
+	clkdata->wm831x = wm831x;
 	/* XTAL_ENA can only be set via OTP/InstantConfig so just read once */
 	ret = wm831x_reg_read(wm831x, WM831X_CLOCK_CONTROL_2);
 	if (ret < 0) {

More information about the kernel-team mailing list