[ 3.5.y.z extended stable ] Patch "usb: ehci-mxc: check for pdata before dereferencing" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Fri Sep 20 19:32:54 UTC 2013

This is a note to let you know that I have just added a patch titled

    usb: ehci-mxc: check for pdata before dereferencing

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:


If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



>From fb28fa89160e37468995b284061a69d81a7deb91 Mon Sep 17 00:00:00 2001
From: Daniel Mack <zonque at gmail.com>
Date: Wed, 21 Aug 2013 11:17:21 +0200
Subject: [PATCH] usb: ehci-mxc: check for pdata before dereferencing

commit f375fc520d4df0cd9fcb570f33c103c6c0311f9e upstream.

Commit 7e8d5cd93fac ("USB: Add EHCI support for MX27 and MX31 based
boards") introduced code that could potentially lead to a NULL pointer
dereference on driver removal.

Fix this by checking for the value of pdata before dereferencing it.

Signed-off-by: Daniel Mack <zonque at gmail.com>
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
[ luis: backported to 3.5: adjusted context ]
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
 drivers/usb/host/ehci-mxc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
index c778ffe..7bce025 100644
--- a/drivers/usb/host/ehci-mxc.c
+++ b/drivers/usb/host/ehci-mxc.c
@@ -291,7 +291,7 @@ static int __exit ehci_mxc_drv_remove(struct platform_device *pdev)
 	if (pdata && pdata->exit)

-	if (pdata->otg)
+	if (pdata && pdata->otg)


More information about the kernel-team mailing list