[Acked] [Precise][SRU][PATCH 0/2] inetpeer: Invalidate the inetpeer tree along with the routing cache

Andy Whitcroft apw at canonical.com
Wed Sep 11 11:13:08 UTC 2013


On Tue, Sep 10, 2013 at 04:26:40PM -0400, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1205741
> 
> == Precise SRU Justification ==
> 
> There is a bug in the the management of inet peers which prevents route metrics like initcwnd from being inherited by route cache entries.  This bug has been fixed upstream in v3.5 by these two commits.  Both commits were cleanly cherry picked from 3.5 into Precise.  A request was submitted upstream to have these commits also included in v3.2[0].  This SRU request is to carry these patches until they make their way down to Precise from upstream 3.2 stable.
> 
> [0] https://lkml.org/lkml/2013/9/10/452
> 
> == Fixes ==
> 
> commit 5faa5df1fa2024bd750089ff21dcc4191798263d
> Author: Steffen Klassert <steffen.klassert at secunet.com>
> Date:   Tue Mar 6 21:20:26 2012 +0000
> 
>     inetpeer: Invalidate the inetpeer tree along with the routing cache
> 
> 
> Also note that commit 5faa5df introduced a race condition that is fixed by mainline commit 55432d2, so this commit is also required:
> 
> commit 55432d2b543a4b6dfae54f5c432a566877a85d90
> Author: Eric Dumazet <edumazet at google.com>
> Date:   Tue Jun 5 03:00:18 2012 +0000
> 
>     inetpeer: fix a race in inetpeer_gc_worker()
> 
> 
> == Test Case ==
> 
> A test kernel was built with these patches and tested by the original bug reporter.  The bug reporter states the test kernel resolved the bug.
> 
> 
> 
> Eric Dumazet (1):
>   inetpeer: fix a race in inetpeer_gc_worker()
> 
> Steffen Klassert (1):
>   inetpeer: Invalidate the inetpeer tree along with the routing cache
> 
>  include/net/inetpeer.h |    6 ++++
>  net/ipv4/inetpeer.c    |   88 +++++++++++++++++++++++++++++++++++++++++++++++-
>  net/ipv4/route.c       |    1 +
>  3 files changed, 94 insertions(+), 1 deletion(-)

These both seem to be clean cherry picks, and to do what is claimed.

Acked-by: Andy Whitcroft <apw at canonical.com>

-apw




More information about the kernel-team mailing list