[PATCH 01/58] drm/i915/lvds: ditch ->prepare special case

Luis Henriques luis.henriques at canonical.com
Mon Sep 2 08:53:46 UTC 2013 -stable review patch.  If anyone has any objections, please let me know.


From: Daniel Vetter <daniel.vetter at ffwll.ch>

commit 520c41cf2fa029d1e8b923ac2026f96664f17c4b upstream.

LVDS is the first output where dpms on/off and prepare/commit don't
perfectly match. Now the idea behind this special case seems to be
that for simple resolution changes on the LVDS we don't need to stop
the pipe, because (at least on newer chips) we can adjust the panel
fitter on the fly.

There are a few problems with the current code though:
- We still stop and restart the pipe unconditionally, because the crtc
  helper code isn't flexible enough.
- We show some ugly flickering, especially when changing crtcs (this
  the crtc helper would actually take into account, but we don't
  implement the encoder->get_crtc callback required to make this work

So it doesn't even work as advertised. I agree that it would be nice
to do resolution changes on LVDS (and also eDP) whithout blacking the
screen where the panel fitter allows to do that. But imo we should
implement this as a special case a few layers up in the mode set code,
akin to how we already detect simple framebuffer changes (and only
update the required registers with ->mode_set_base).

Until this is all in place, make our lives easier and just rip it out.

Also note that this seems to fix actual bugs with enabling the lvds
output, see:


Cc: Takashi Iwai <tiwai at suse.de>
Cc: Giacomo Comes <comes at naic.edu>
Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
Tested-by: Takashi Iwai <tiwai at suse.de>
Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Cc: Haitao Zhang <haitao.zhang at canonical.com>
Cc: Anthony Wong <anthony.wong at canonical.com>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
 drivers/gpu/drm/i915/intel_lvds.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index 440ed88..30a6a15 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -408,13 +408,7 @@ static void intel_lvds_prepare(struct drm_encoder *encoder)
 	struct intel_lvds *intel_lvds = to_intel_lvds(encoder);
-	/*
-	 * Prior to Ironlake, we must disable the pipe if we want to adjust
-	 * the panel fitter. However at all other times we can just reset
-	 * the registers regardless.
-	 */
-	if (!HAS_PCH_SPLIT(encoder->dev) && intel_lvds->pfit_dirty)
-		intel_lvds_disable(intel_lvds);
+	intel_lvds_disable(intel_lvds);
 static void intel_lvds_commit(struct drm_encoder *encoder)

More information about the kernel-team mailing list