Ack: [Quantal][SRU][PATCH 0/2] Add xhci lpm BESL support
Brad Figg
brad.figg at canonical.com
Thu Oct 10 20:34:16 UTC 2013
On 09/25/2013 07:27 AM, Gavin Guo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1229576
>
> == Quantal SRU Justification ==
>
> The patches cherry-picked from upstream add implementaion of BESL
> support to xhci driver and set the BESL duration to 400us by default,
> which can reduce the sleep time and increase the transfer time for
> bulk transfer to avoid the camera buffer overflow.
>
> == Fix ==
>
> commit b6e76371c888f5cb677f190a28444ac8875359ad
> Author: Mathias Nyman <mathias.nyman at linux.intel.com>
> Date: Thu May 23 17:14:29 2013 +0300
>
> usb: xhci: define port register names and use them instead of magic numbers
>
> Also there is little conflict happened when cherry-picked the commit, there is no
> big modifications to the code, just added the patches.
>
> commit a558ccdcc71c7770c5e80c926a31cfe8a3892a09
> Author: Mathias Nyman <mathias.nyman at linux.intel.com>
> Date: Thu May 23 17:14:30 2013 +0300
>
> usb: xhci: add USB2 Link power management BESL support
>
> usb 2.0 devices with link power managment (LPM) can describe their idle link
> timeouts either in BESL or HIRD format, so far xHCI has only supported HIRD but
> later xHCI errata add BESL support as well
>
> BESL timeouts need to inform exit latency changes with an evaluate
> context command the same way USB 3.0 link PM code does.
> The same xhci_change_max_exit_latency() function is used as with USB3
> but code is pulled out from #ifdef CONFIG_PM as USB2.0 BESL LPM
> funcionality does not depend on CONFIG_PM.
>
>
> == Test Case ==
>
> A test kernel was built with these patches and tested by the original bug reporter. The bug reporter states the test kernel resolved the bug.
>
> Mathias Nyman (2):
> usb: xhci: define port register names and use them instead of magic
> numbers
> usb: xhci: add USB2 Link power management BESL support
>
> drivers/usb/host/xhci-hub.c | 16 ++--
> drivers/usb/host/xhci.c | 205 +++++++++++++++++++++++++++++--------------
> drivers/usb/host/xhci.h | 26 ++++++
> 3 files changed, 172 insertions(+), 75 deletions(-)
>
--
Brad Figg brad.figg at canonical.com http://www.canonical.com
More information about the kernel-team
mailing list