ACK: [Quantal][SRU][PATCH 2/2] usb: xhci: add USB2 Link power management BESL support

[Tim Gardner]

On 10/08/2013 11:20 PM, Shawn Wang wrote:
> Hi Tim,
> 
>   Sorry about the late reply.
>   I tested the other three platforms for the BESL patch.
>   Is the coverage good enough?
> 
>  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1229576/comments/7
> Test 3 other usb chipsets, all of the usb functions are good.
> 
> ==> amz-pst-c2/lspci <==
> 00:00.0 Host bridge: Intel Corporation Haswell DRAM Controller (rev 06)
> ==> me5-e3-i1/lspci <==
> 00:00.0 Host bridge: Intel Corporation Ivy Bridge DRAM Controller (rev 08)
> ==> osaka8/lspci <==
> 00:00.0 Host bridge: Advanced Micro Devices [AMD] Family 14h Processor
> Root Complex
> 
> Regards,
> Shawn
> 
> 
> On Wed, Oct 9, 2013 at 12:50 PM, Anthony Wong
> <anthony.wong at canonical.com <mailto:anthony.wong at canonical.com>> wrote:
> 
>     Hi Shawn -- I think we have a good coverage here and you can ping
>     Tim again to let him know.
> 
>     Thanks,
>     Anthony
> 
>     -- 
>     Anthony Wong <anthony.wong at canonical.com
>     <mailto:anthony.wong at canonical.com>>
>     Project Manager, Hardware Enablement
>     Mobile: +86 1860-8989-064 <tel:%2B86%201860-8989-064>
>     Canonical Ltd.      www.canonical.com <http://www.canonical.com/>
> 
> 
>     On 9 October 2013 10:55, Shawn Wang <shawn.wang at canonical.com
>     <mailto:shawn.wang at canonical.com>> wrote:
> 
>         Hi Anthony, 
>           I'm not sure about the regression test.
>           Could you help about it?
> 
>           I test the other three platforms.
> 
>          https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1229576/comments/7
>         Test 3 other usb chipsets, all of the usb functions are good.
> 
>         ==> amz-pst-c2/lspci <==
>         00:00.0 Host bridge: Intel Corporation Haswell DRAM Controller
>         (rev 06)
>         ==> me5-e3-i1/lspci <==
>         00:00.0 Host bridge: Intel Corporation Ivy Bridge DRAM
>         Controller (rev 08)
>         ==> osaka8/lspci <==
>         00:00.0 Host bridge: Advanced Micro Devices [AMD] Family 14h
>         Processor Root Complex
> 
>         Regards,
>         Shawn
>         ---------- Forwarded message ----------
>         From: *Tim Gardner* <tim.gardner at canonical.com
>         <mailto:tim.gardner at canonical.com>>
>         Date: Mon, Sep 30, 2013 at 10:25 PM
>         Subject: Re: [Quantal][SRU][PATCH 2/2] usb: xhci: add USB2 Link
>         power management BESL support
>         To: Shawn Wang <shawn.wang at canonical.com
>         <mailto:shawn.wang at canonical.com>>
>         Cc: Gavin Guo <gavin.guo at canonical.com
>         <mailto:gavin.guo at canonical.com>>, kernel-team at lists.ubuntu.com
>         <mailto:kernel-team at lists.ubuntu.com>, Anthony Wong
>         <anthony.wong at canonical.com <mailto:anthony.wong at canonical.com>>
> 
> 
>         On 09/30/2013 02:14 AM, Shawn Wang wrote:
>         > Hi Tim,
>         >  I did some regression tests and posted it
>         > on https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1229576.
>         >
>         > Webcam test:
>         >  preview with resolution change (cheese/guvcview)
>         >  Take photos.
>         >  S3 stress 30 times than preview and take photos.
>         >
>         > Other usb device test:
>         >  USB mouse (8564:1000)
>         >  usb disk (0781:5571 SanDisk Corp.)
>         >  usb bt (8087:07dc)
>         >
>         > Regards,
>         > Shawn
>         >
> 
>         It is not clear from your test results that you have regression
>         tested
>         other platforms. I'm reasonably sure you would have noticed
>         regressions
>         with other USB devices on the _same_ platform as the camera
>         under test.
> 
>         rtg
>         --
>         Tim Gardner tim.gardner at canonical.com
>         <mailto:tim.gardner at canonical.com>
> 
> 
> 


-- 
Tim Gardner tim.gardner at canonical.com