[PATCH 2/3] net: calxedaxgmac: add uc and mc filter addresses in promiscuous mode
Paolo Pisati
paolo.pisati at canonical.com
Fri Oct 4 14:06:27 UTC 2013
From: Rob Herring <rob.herring at calxeda.com>
Even in promiscuous mode, we need to add filter addresses for correct
operation. This fixes silent failures when using a bridge and adding
addresses using the "bridge fdb add" command.
Signed-off-by: Rob Herring <rob.herring at calxeda.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit 8a8c3f5bebe2455200cd488aea8546d01645b06b)
Signed-off-by: Paolo Pisati <paolo.pisati at canonical.com>
---
drivers/net/ethernet/calxeda/xgmac.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index 94358d2..35da09b 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -1291,10 +1291,8 @@ static void xgmac_set_rx_mode(struct net_device *dev)
netdev_dbg(priv->dev, "# mcasts %d, # unicast %d\n",
netdev_mc_count(dev), netdev_uc_count(dev));
- if (dev->flags & IFF_PROMISC) {
- writel(XGMAC_FRAME_FILTER_PR, ioaddr + XGMAC_FRAME_FILTER);
- return;
- }
+ if (dev->flags & IFF_PROMISC)
+ value |= XGMAC_FRAME_FILTER_PR;
memset(hash_filter, 0, sizeof(hash_filter));
--
1.8.3.2
More information about the kernel-team
mailing list