ACK: [Precise][SRU] kernel-doc: bugfix - multi-line macros

Stefan Bader stefan.bader at canonical.com
Wed Oct 2 08:40:02 UTC 2013


On 02.10.2013 10:17, Luis Henriques wrote:
> From: Daniel Santos <daniel.santos at pobox.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1223920
> 
> Prior to this patch the following code breaks:
> 
> /**
>  * multiline_example - this breaks kernel-doc
>  */
>  #define multiline_example( \
> myparam)
> 
> Producing this error:
> 
> Error(somefile.h:983): cannot understand prototype: 'multiline_example( \ '
> 
> This patch fixes the issue by appending all lines ending in a blackslash
> (optionally followed by whitespace), removing the backslash and any
> whitespace after it prior to appending (just like the C pre-processor
> would).
> 
> This fixes a break in kerel-doc introduced by the additions to rbtree.h.
> 
> Signed-off-by: Daniel Santos <daniel.santos at pobox.com>
> Cc: Randy Dunlap <rdunlap at xenotime.net>
> Cc: Michal Marek <mmarek at suse.cz>
> Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
> (cherry picked from commit 654784284430bf2739985914b65e09c7c35a7273)
> Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
> ---
>  scripts/kernel-doc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index d793001..ba3d9df 100755
> --- a/scripts/kernel-doc
> +++ b/scripts/kernel-doc
> @@ -2044,6 +2044,9 @@ sub process_file($) {
>  
>      $section_counter = 0;
>      while (<IN>) {
> +	while (s/\\\s*$//) {
> +	    $_ .= <IN>;
> +	}
>  	if ($state == 0) {
>  	    if (/$doc_start/o) {
>  		$state = 1;		# next line is always the function name
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20131002/4e7730c5/attachment.sig>


More information about the kernel-team mailing list