[PATCH 3.5 74/78] include/linux/fs.h: disable preempt when acquire i_size_seqcount write lock

Luis Henriques luis.henriques at canonical.com
Mon Nov 25 13:07:01 UTC 2013 -stable review patch.  If anyone has any objections, please let me know.


From: Fan Du <fan.du at windriver.com>

commit 74e3d1e17b2e11d175970b85acd44f5927000ba2 upstream.

Two rt tasks bind to one CPU core.

The higher priority rt task A preempts a lower priority rt task B which
has already taken the write seq lock, and then the higher priority rt
task A try to acquire read seq lock, it's doomed to lockup.

rt task A with lower priority: call write
i_size_write                                        rt task B with higher priority: call sync, and preempt task A
  write_seqcount_begin(&inode->i_size_seqcount);    i_size_read
  inode->i_size = i_size;                             read_seqcount_begin <-- lockup here...

So disable preempt when acquiring every i_size_seqcount *write* lock will
cure the problem.

Signed-off-by: Fan Du <fan.du at windriver.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
Cc: Zhao Hongjiang <zhaohongjiang at huawei.com>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
 include/linux/fs.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 17fd887..65b8b69 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -925,9 +925,11 @@ static inline loff_t i_size_read(const struct inode *inode)
 static inline void i_size_write(struct inode *inode, loff_t i_size)
 #if BITS_PER_LONG==32 && defined(CONFIG_SMP)
+	preempt_disable();
 	inode->i_size = i_size;
+	preempt_enable();
 #elif BITS_PER_LONG==32 && defined(CONFIG_PREEMPT)
 	inode->i_size = i_size;

More information about the kernel-team mailing list