[Lucid][CVE-2013-4345] crypto: ansi_cprng - Fix off by one error in non-block size request

Luis Henriques luis.henriques at canonical.com
Mon Nov 25 11:19:01 UTC 2013


From: Neil Horman <nhorman at tuxdriver.com>

CVE-2013-4345

BugLink: http://bugs.launchpad.net/bugs/1229981

Stephan Mueller reported to me recently a error in random number generation in
the ansi cprng. If several small requests are made that are less than the
instances block size, the remainder for loop code doesn't increment
rand_data_valid in the last iteration, meaning that the last bytes in the
rand_data buffer gets reused on the subsequent smaller-than-a-block request for
random data.

The fix is pretty easy, just re-code the for loop to make sure that
rand_data_valid gets incremented appropriately

Signed-off-by: Neil Horman <nhorman at tuxdriver.com>
Reported-by: Stephan Mueller <stephan.mueller at atsec.com>
CC: Stephan Mueller <stephan.mueller at atsec.com>
CC: Petr Matousek <pmatouse at redhat.com>
CC: Herbert Xu <herbert at gondor.apana.org.au>
CC: "David S. Miller" <davem at davemloft.net>
Signed-off-by: Herbert Xu <herbert at gondor.apana.org.au>
(cherry picked from commit 714b33d15130cbb5ab426456d4e3de842d6c5b8a)
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 crypto/ansi_cprng.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c
index 3aa6e38..0ffd5995 100644
--- a/crypto/ansi_cprng.c
+++ b/crypto/ansi_cprng.c
@@ -232,11 +232,11 @@ remainder:
 	 */
 	if (byte_count < DEFAULT_BLK_SZ) {
 empty_rbuf:
-		for (; ctx->rand_data_valid < DEFAULT_BLK_SZ;
-			ctx->rand_data_valid++) {
+		while (ctx->rand_data_valid < DEFAULT_BLK_SZ) {
 			*ptr = ctx->rand_data[ctx->rand_data_valid];
 			ptr++;
 			byte_count--;
+			ctx->rand_data_valid++;
 			if (byte_count == 0)
 				goto done;
 		}
-- 
1.8.3.2




More information about the kernel-team mailing list