[PATCH 0/5] Raring SRU: Backport dell headset functionality

Andy Whitcroft apw at canonical.com
Thu Nov 21 11:48:03 UTC 2013


On Thu, Nov 21, 2013 at 11:36:46AM +0100, David Henningsson wrote:
> Hi,
> 
> This is a relatively big patch set, and I wouldn't have tried backporting it
> unless it was blocking certification for several machines (see bugs 1169143
> and 1249956).
> 
> In short; the big patch of these concerns explicitly quirked machines, and the 
> other patches - that touches more generic code - were quite straight forward to
> backport. We introduce two variables (is_headphone_mic and is_headset_mic), set
> these only in the quirks, and the rest is just taking different code paths if
> these variables are set.
> 
> There is one caveat: I strongly suspect that we will also need a 13.04 PulseAudio
> SRU to avoid a regression for people running 13.04, similar to what we have
> already done for 12.04.
> 
> Also; there are like 5-10 more patches, which all just add one or two lines in
> the quirk table. Do you prefer me to cherrypick these one by one, or squash them
> into one patch?
> 
> I'm still waiting for final test results, and I should probably run a quick
> regression testing on an unrelated machine to make sure I don't break anything,
> but I wanted to give you a heads up right now. I want to hear what you think
> about this patch set, as well as a deadline for when this needs to be finished
> for it to reach next SRU cycle (some time next week, right?).

Overall though the set seems big the majority seems to be new code which
is only used on specific system models.  So I guess it should be ok.  I
assume you are up for handling any fallout from stable patches on this
area.

I see you have not signed off all of these as yet, and imply there are
some more quirk table patches coming for other machines, so I am not
going to ack this set but will wait for the 'complete' version.  For me
I would prefer to keep any patches which can be cherry-picks as such for
these additional quirks.

-apw




More information about the kernel-team mailing list